* + mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch added to mm-new branch
@ 2026-08-30 2:26 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-08-30 2:26 UTC (permalink / raw)
To: mm-commits, shakeel.butt, rientjes, mhocko, liuye, akpm
The patch titled
Subject: mm/oom_kill: remove unreachable __GFP_THISNODE check in constrained_alloc()
has been added to the -mm mm-new branch. Its filename is
mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Ye Liu <liuye@kylinos.cn>
Subject: mm/oom_kill: remove unreachable __GFP_THISNODE check in constrained_alloc()
Date: Thu, 13 Aug 2026 17:38:09 +0800
The __GFP_THISNODE check in constrained_alloc() is dead code: global OOM
is never triggered with __GFP_THISNODE (blocked in __alloc_pages_may_oom
before out_of_memory() is called), and memcg OOM returns CONSTRAINT_MEMCG
at the top of the function before reaching this point. Remove the check,
its stale comment, and update the following comment that referenced
__GFP_THISNODE.
Link: https://lore.kernel.org/20260813093810.573302-1-ye.liu@linux.dev
Signed-off-by: Ye Liu <liuye@kylinos.cn>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: David Rientjes <rientjes@google.com>
Cc: Liu Ye <liuye@kylinos.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/oom_kill.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
--- a/mm/oom_kill.c~mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc
+++ a/mm/oom_kill.c
@@ -267,18 +267,11 @@ static enum oom_constraint constrained_a
if (!oc->zonelist)
return CONSTRAINT_NONE;
- /*
- * Reach here only when __GFP_NOFAIL is used. So, we should avoid
- * to kill current.We have to random task kill in this case.
- * Hopefully, CONSTRAINT_THISNODE...but no way to handle it, now.
- */
- if (oc->gfp_mask & __GFP_THISNODE)
- return CONSTRAINT_NONE;
/*
- * This is not a __GFP_THISNODE allocation, so a truncated nodemask in
- * the page allocator means a mempolicy is in effect. Cpuset policy
- * is enforced in get_page_from_freelist().
+ * A truncated nodemask in the page allocator means a mempolicy
+ * is in effect. Cpuset policy is enforced in
+ * get_page_from_freelist().
*/
if (oc->nodemask &&
!nodes_subset(node_states[N_MEMORY], *oc->nodemask)) {
_
Patches currently in -mm which might be from liuye@kylinos.cn are
mm-vmalloc-fix-vmap_purge_lock-livelock-under-memory-pressure.patch
tools-mm-page_owner_sort-fix-sort-option-being-silently-ignored.patch
tools-mm-page_owner_sort-add-module-name-sort-cull-filter-support.patch
tools-mm-page_owner_sort-show-available-sort-keys-in-usage-text.patch
mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-30 2:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 2:26 + mm-oom_kill-remove-unreachable-__gfp_thisnode-check-in-constrained_alloc.patch added to mm-new branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.