* [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level
@ 2026-08-30 5:42 Donggeun Yoo
2026-08-30 15:41 ` Joshua Crofts
0 siblings, 1 reply; 3+ messages in thread
From: Donggeun Yoo @ 2026-08-30 5:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: Donggeun Yoo, linux-iio, linux-kernel
Use sysfs_emit() instead of sprintf() for writing to the sysfs
output buffer. sysfs_emit() is aware of the buffer's PAGE_SIZE
limit and is the preferred helper for sysfs callbacks.
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
---
drivers/iio/light/vcnl4000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 336468d59ea7..dac235dd6220 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -1504,7 +1504,7 @@ static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
{
struct vcnl4000_data *data = iio_priv(indio_dev);
- return sprintf(buf, "%u\n", data->near_level);
+ return sysfs_emit(buf, "%u\n", data->near_level);
}
static irqreturn_t vcnl4010_irq_thread(int irq, void *p)
base-commit: 350d1fb9204b13c5f95e511e98b8bcb47574d425
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level
2026-08-30 5:42 [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level Donggeun Yoo
@ 2026-08-30 15:41 ` Joshua Crofts
2026-08-30 19:01 ` Donggeun Yoo
0 siblings, 1 reply; 3+ messages in thread
From: Joshua Crofts @ 2026-08-30 15:41 UTC (permalink / raw)
To: Donggeun Yoo
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
linux-iio, linux-kernel
On Sun, 30 Aug 2026 14:42:36 +0900
Donggeun Yoo <donggeunyoo.kernel@gmail.com> wrote:
> Use sysfs_emit() instead of sprintf() for writing to the sysfs
> output buffer. sysfs_emit() is aware of the buffer's PAGE_SIZE
> limit and is the preferred helper for sysfs callbacks.
>
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> ---
> drivers/iio/light/vcnl4000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 336468d59ea7..dac235dd6220 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -1504,7 +1504,7 @@ static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
> {
> struct vcnl4000_data *data = iio_priv(indio_dev);
>
> - return sprintf(buf, "%u\n", data->near_level);
> + return sysfs_emit(buf, "%u\n", data->near_level);
You should also include <linux/sysfs.h>.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level
2026-08-30 15:41 ` Joshua Crofts
@ 2026-08-30 19:01 ` Donggeun Yoo
0 siblings, 0 replies; 3+ messages in thread
From: Donggeun Yoo @ 2026-08-30 19:01 UTC (permalink / raw)
To: Joshua Crofts
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
linux-iio, linux-kernel
> You should also include <linux/sysfs.h>.
Thanks, added in v2.
On Mon, Aug 31, 2026 at 12:41 AM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> On Sun, 30 Aug 2026 14:42:36 +0900
> Donggeun Yoo <donggeunyoo.kernel@gmail.com> wrote:
>
> > Use sysfs_emit() instead of sprintf() for writing to the sysfs
> > output buffer. sysfs_emit() is aware of the buffer's PAGE_SIZE
> > limit and is the preferred helper for sysfs callbacks.
> >
> > Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> > ---
> > drivers/iio/light/vcnl4000.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> > index 336468d59ea7..dac235dd6220 100644
> > --- a/drivers/iio/light/vcnl4000.c
> > +++ b/drivers/iio/light/vcnl4000.c
> > @@ -1504,7 +1504,7 @@ static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
> > {
> > struct vcnl4000_data *data = iio_priv(indio_dev);
> >
> > - return sprintf(buf, "%u\n", data->near_level);
> > + return sysfs_emit(buf, "%u\n", data->near_level);
>
> You should also include <linux/sysfs.h>.
>
> --
> Kind regards,
> Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-30 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 5:42 [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level Donggeun Yoo
2026-08-30 15:41 ` Joshua Crofts
2026-08-30 19:01 ` Donggeun Yoo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.