Re: [PATCH v16 12/22] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `i2c-alias-pool` property is incorrectly restricted to a maximum of 2 aliases, which breaks schema validation for standard dual-link topologies.
- [Low] The `#address-cells` and `#size-cells` properties are missing from the `required` list inside the `i2c-atr` node schema.
--

commit 7472cadfe0a14fe6a0a18b63a3ea7a85e2d94a8a
Author: Cosmin Tanislav <demonsingur@gmail.com>

dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

This commit introduces device tree bindings for the MAX9296A, MAX96716A,
and MAX96792A GMSL to CSI-2 deserializers. It documents properties for
I2C address translation, ports, and endpoint configurations.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
> new file mode 100644
> index 0000000000000..de6bfcec5dc63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
[ ... ]
> +  port0-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 0
> +
> +  port1-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 1
> +
> +  i2c-alias-pool:
> +    maxItems: 2

[Severity: Medium]
Does this maximum item limit of 2 restrict valid hardware configurations?

Device trees that configure more than two remote I2C devices, such as a
standard dual-link topology with 2 serializers and 2 image sensors, will
fail schema validation because i2c-alias-pool is strictly limited to a
maximum of 2 items. The entire deserializer would only be allowed to allocate
2 aliases for all downstream devices.

> +
> +  i2c-atr:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +

[Severity: Low]
Should #address-cells and #size-cells be listed under a required block
for the i2c-atr node schema?

Because #address-cells and #size-cells are not listed under required in the
i2c-atr object schema, a device tree omitting these properties will silently
pass schema validation, even though it defines unit-addressed children
(^i2c@[0-1]$).

> +    patternProperties:
> +      '^i2c@[0-1]$':
> +        $ref: /schemas/i2c/i2c-controller.yaml#
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-gmsl2-3_serdes-v16-0-4fa6e08bb514@analog.com?part=12