[PATCH net v3 0/3] pds_core: fixes for the PCI reset path

["Nikhil P. Rao" <nikhil.rao@amd.com>]

The v2 review raised several issues beyond the cmd_regs race, so v3 is a
series rather than a single patch.

Patch 1 is the v2 patch with the pdsc_core_init() and
pdsc_identify_ver() checks removed. Those checks are dead code. commit
cd09971dcc1c ("pds_core: keep the health thread stopped during reset")
disables health_work across the reset, so the health thread can no
longer reach pdsc_setup() with the BARs unmapped. The only other callers
are probe and pdsc_reset_done(), and both map the BARs earlier in the
same call, so cmd_regs cannot be NULL by the time they get there.

The pdsc_core_init() check is also worse than what it replaces. Its
bail-out jumps to err_out_uninit, which ends up in pdsc_intr_free() and
writes to pdsc->intr_ctrl, also NULL at that point.

On v2 I said I would convert pdsc_identify() and pdsc_core_init() to
pdsc_devcmd_with_data() once the PLDM series landed. Dropping that: the
helper has no read-back path and both callers need one, and giving them
an -ENXIO return means hardening pdsc_intr_free() against a NULL
intr_ctrl on the err_out_uninit path. That is a lot of churn to
deduplicate two call sites.

Patch 2 is the VF pci_release_regions() fix, older than the cmd_regs
race, so it carries its own Fixes tag.

Patch 3 is the identity_show() NULL deref.

The v2 changelog claim that pdsc_unmap_bars() clears db_pages was wrong.
It clears info_regs, cmd_regs, intr_status and intr_ctrl; db_pages is
never mapped.

v2: https://lore.kernel.org/netdev/20260804235946.177762-1-nikhil.rao@amd.com/
v1: https://lore.kernel.org/netdev/20260729055258.1416225-1-nikhil.rao@amd.com/

Nikhil P. Rao (3):
  pds_core: fix cmd_regs access racing BAR unmap on reset
  pds_core: don't release PCI regions for VFs on reset
  pds_core: check info_regs in the identity debugfs reader

 drivers/net/ethernet/amd/pds_core/debugfs.c |  5 +++--
 drivers/net/ethernet/amd/pds_core/fw.c      | 10 +++++++++-
 drivers/net/ethernet/amd/pds_core/main.c    | 10 ++++++++--
 3 files changed, 20 insertions(+), 5 deletions(-)

-- 
2.43.0