From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: nikhil.rao@amd.com, netdev@vger.kernel.org, pabeni@redhat.com,
brett.creeley@amd.com, eric.joyner@amd.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com
Subject: Re: [PATCH net v3 3/3] pds_core: check info_regs in the identity debugfs reader
Date: Fri, 4 Sep 2026 18:21:52 -0700 [thread overview]
Message-ID: <20260904182152.489856d5@kernel.org> (raw)
In-Reply-To: <178857041188.219967.13424554495565611887@kernel.org>
On Sat, 05 Sep 2026 01:06:51 +0000 netdev-bot+sashiko@kernel.org wrote:
> > - seq_printf(seq, "fw_heartbeat: 0x%x\n",
> > - ioread32(&pdsc->info_regs->fw_heartbeat));
> > + if (pdsc->info_regs)
> > + seq_printf(seq, "fw_heartbeat: 0x%x\n",
> > + ioread32(&pdsc->info_regs->fw_heartbeat));
>
> [Severity: Medium]
> Is the guard enough when the unmap happens concurrently with the read?
> The test and the use are two separate plain loads of pdsc->info_regs,
> and identity_show() holds none of the driver's locks:
If the comment is correct the patch is pointless in its current form..
next prev parent reply other threads:[~2026-09-05 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 4:42 [PATCH net v3 0/3] pds_core: fixes for the PCI reset path Nikhil P. Rao
2026-09-01 4:42 ` [PATCH net v3 1/3] pds_core: fix cmd_regs access racing BAR unmap on reset Nikhil P. Rao
2026-09-01 4:42 ` [PATCH net v3 2/3] pds_core: don't release PCI regions for VFs " Nikhil P. Rao
2026-09-05 1:06 ` netdev-bot+sashiko
2026-09-05 1:21 ` Jakub Kicinski
2026-09-01 4:42 ` [PATCH net v3 3/3] pds_core: check info_regs in the identity debugfs reader Nikhil P. Rao
2026-09-05 1:06 ` netdev-bot+sashiko
2026-09-05 1:21 ` Jakub Kicinski [this message]
2026-09-05 1:10 ` [PATCH net v3 0/3] pds_core: fixes for the PCI reset path patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904182152.489856d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.