From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, Ani Sinha <anisinha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PULL 13/13] hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op
Date: Tue, 1 Sep 2026 10:25:46 +0200 [thread overview]
Message-ID: <20260901082554.804169-14-kraxel@redhat.com> (raw)
In-Reply-To: <20260901082554.804169-1-kraxel@redhat.com>
From: Ani Sinha <anisinha@redhat.com>
The control bits define the behavior of the interface and clearing the bits
upon reading or select operation will break that behavior. For example, after
CTL_HOST_IGVM is set by the guest through a write and then subsequently, if the
guest tried to read back the values from the fw-cfg interface, the read would
clear CTL_HOST_IGVM. This would break restoring the host IGVM upon subsequent
reset.
Fixes: 30688c02a76e50e4 ("hw/misc/vmlaunchupdate: Introduce hypervisor fw-cfg interface support")
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Message-ID: <20260825124139.6900-1-anisinha@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/misc/vmlaunchupdate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/misc/vmlaunchupdate.c b/hw/misc/vmlaunchupdate.c
index afa2d278aefc..847d2d963f10 100644
--- a/hw/misc/vmlaunchupdate.c
+++ b/hw/misc/vmlaunchupdate.c
@@ -41,7 +41,6 @@ static bool vmlaunchupdate_supported(void)
static void init_vm_launch_update(VMLaunchUpdateState *s)
{
s->launch_update.capabilities = VM_LAUNCHUPDATE_FORMAT_IGVM;
- s->launch_update.control = 0;
if (s->disabled) {
s->launch_update.control |= VM_LAUNCHUPDATE_CTL_DISABLE;
--
2.55.0
next prev parent reply other threads:[~2026-09-01 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:25 [PULL 00/13] Firmware 20260901 patches Gerd Hoffmann
2026-09-01 8:25 ` [PULL 01/13] tests/acpi: enable updates Gerd Hoffmann
2026-09-01 8:25 ` [PULL 02/13] edk2: update build script Gerd Hoffmann
2026-09-01 8:25 ` [PULL 03/13] edk2: update submodule to edk2-stable202608 Gerd Hoffmann
2026-09-01 8:25 ` [PULL 04/13] edk2: drop 32-bit build config (ia32 and arm), update aarch64 vars Gerd Hoffmann
2026-09-01 8:25 ` [PULL 06/13] edk2: rename risc-v firmware builds Gerd Hoffmann
2026-09-01 8:25 ` [PULL 08/13] tests/acpi: log the name of the table checked Gerd Hoffmann
2026-09-01 8:25 ` [PULL 09/13] tests/acpi: skip FPDT oem field test Gerd Hoffmann
2026-09-01 8:25 ` [PULL 10/13] tests/acpi: update expected data files Gerd Hoffmann
2026-09-01 8:25 ` [PULL 11/13] tests/acpi: add FPDT table data for loongarch Gerd Hoffmann
2026-09-01 8:25 ` [PULL 12/13] tests/acpi: disable updates Gerd Hoffmann
2026-09-01 8:25 ` Gerd Hoffmann [this message]
2026-09-01 13:20 ` [PULL 00/13] Firmware 20260901 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901082554.804169-14-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.