Re: [RFC PATCH 14/19] vfio/pci: Add generic PCI error slot reset handling

[sashiko-bot@kernel.org]

> Add a slot_reset() handler for vfio-pci-core.
> 
> Restore the saved PCI state first. The host resets the link without
> restoring config space, so on entry the BARs read as zero, and tearing
> down MSI-X before the restore would write through a stale table address
> the device no longer decodes.
> 
> Then tear down the stale interrupt configuration, holding recovery_lock
> across it. vfio_pci_core_disable() runs the same interrupt teardown when
> the device is closed and takes no igate, relying on there being no other
> user by then. vfio_msi_set_vector_signal() frees the per-vector context
> with no atomicity between the lookup and the erase, so two callers which
> both find it free the irq, the name and the eventfd context twice.
> vfio_pci_core_prepare_close() takes recovery_lock for writing before it,
> so holding it here keeps close out.
> [ ... ]
> The handler does nothing until a later patch starts a recovery
> transaction.
> 
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901093217.8539-1-skolothumtho@nvidia.com?part=14