Re: [RFC PATCH 19/19] vfio/pci: Expose and enable host PCI error recovery

[sashiko-bot@kernel.org]

> Add a VFIO device feature that reports whether host PCI recovery is
> enabled, whether recovery is in progress, whether the channel was frozen,
> whether the host reset the device, and whether recovery failed. A sequence
> number lets userspace distinguish events.
> 
> Installing a dedicated recovery eventfd enables recovery. The eventfd is
> additional to VFIO_PCI_ERR_IRQ_INDEX, which keeps reporting errors as it
> does today either way. Recovery can be disabled only when not in progress
> and before terminal failure. Reject both enable and disable while device
> access is blocked so feature changes cannot race lifecycle teardown or an
> explicit reset.
> 
> Clear the sequence number and the status bits whichever way the feature is
> being changed, so a sequence number always describes an event the eventfd
> holding it was notified of. A user which replaces the eventfd would
> otherwise read status for an event it never heard about.
> 
> Variant drivers return -ENOTTY as they do not advertise recovery support.
> 
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901093217.8539-1-skolothumtho@nvidia.com?part=19