All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Billy Tsai" <billy_tsai@aspeedtech.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	linux-i3c@lists.infradead.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	Frank.Li@kernel.org
Subject: Re: [PATCH 2/8] i3c: mipi-i3c-hci: Support address-indexed DAT slots
Date: Tue, 01 Sep 2026 11:49:04 +0000	[thread overview]
Message-ID: <20260901114905.10CE71F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260901-b4-i3c-hci-ast2700-v1-2-19909e7cbd7e@aspeedtech.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `HCI_DAT_ANY_ADDRESS` is defined but never used.
--

commit 8ebe233a1f220dcff7a28a779f787f8b63ea1787
Author: Billy Tsai <billy_tsai@aspeedtech.com>

i3c: mipi-i3c-hci: Support address-indexed DAT slots

This commit introduces the HCI_QUIRK_DAT_INDEX_IS_ADDR quirk to support
ASPEED I3C controllers. Controllers with this quirk allocate DAT slots
based directly on the device's 7-bit address instead of using sequential
DAT slot assignments.

[ ... ]

> diff --git a/drivers/i3c/master/mipi-i3c-hci/dat.h b/drivers/i3c/master/mipi-i3c-hci/dat.h
> index 6881f19da77f2..d4c7b03724d37 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dat.h
> +++ b/drivers/i3c/master/mipi-i3c-hci/dat.h
> @@ -14,12 +14,13 @@
>  #define DAT_0_I2C_DEVICE		W0_BIT_(31)
>  #define DAT_0_SIR_REJECT		W0_BIT_(13)
>  #define DAT_0_IBI_PAYLOAD		W0_BIT_(12)
> +#define HCI_DAT_ANY_ADDRESS		((unsigned int)-1)

[Severity: Low]
Is HCI_DAT_ANY_ADDRESS intended to be used in this patch series? This macro
is defined here in drivers/i3c/master/mipi-i3c-hci/dat.h but never referenced
anywhere in the codebase or in the remainder of the patch. If it is unused,
can it be removed to prevent dead code?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-b4-i3c-hci-ast2700-v1-0-19909e7cbd7e@aspeedtech.com?part=2

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Billy Tsai" <billy_tsai@aspeedtech.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	linux-i3c@lists.infradead.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	Frank.Li@kernel.org
Subject: Re: [PATCH 2/8] i3c: mipi-i3c-hci: Support address-indexed DAT slots
Date: Tue, 01 Sep 2026 11:49:04 +0000	[thread overview]
Message-ID: <20260901114905.10CE71F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260901-b4-i3c-hci-ast2700-v1-2-19909e7cbd7e@aspeedtech.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `HCI_DAT_ANY_ADDRESS` is defined but never used.
--

commit 8ebe233a1f220dcff7a28a779f787f8b63ea1787
Author: Billy Tsai <billy_tsai@aspeedtech.com>

i3c: mipi-i3c-hci: Support address-indexed DAT slots

This commit introduces the HCI_QUIRK_DAT_INDEX_IS_ADDR quirk to support
ASPEED I3C controllers. Controllers with this quirk allocate DAT slots
based directly on the device's 7-bit address instead of using sequential
DAT slot assignments.

[ ... ]

> diff --git a/drivers/i3c/master/mipi-i3c-hci/dat.h b/drivers/i3c/master/mipi-i3c-hci/dat.h
> index 6881f19da77f2..d4c7b03724d37 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dat.h
> +++ b/drivers/i3c/master/mipi-i3c-hci/dat.h
> @@ -14,12 +14,13 @@
>  #define DAT_0_I2C_DEVICE		W0_BIT_(31)
>  #define DAT_0_SIR_REJECT		W0_BIT_(13)
>  #define DAT_0_IBI_PAYLOAD		W0_BIT_(12)
> +#define HCI_DAT_ANY_ADDRESS		((unsigned int)-1)

[Severity: Low]
Is HCI_DAT_ANY_ADDRESS intended to be used in this patch series? This macro
is defined here in drivers/i3c/master/mipi-i3c-hci/dat.h but never referenced
anywhere in the codebase or in the remainder of the patch. If it is unused,
can it be removed to prevent dead code?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-b4-i3c-hci-ast2700-v1-0-19909e7cbd7e@aspeedtech.com?part=2

  reply	other threads:[~2026-09-01 11:49 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 11:35 [PATCH 0/8] i3c: mipi-i3c-hci: Add Aspeed AST2700 support Billy Tsai
2026-09-01 11:35 ` Billy Tsai
2026-09-01 11:35 ` [PATCH 1/8] dt-bindings: i3c: Document the AST2700 I3C controller Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 20:41   ` Frank Li
2026-09-01 20:41     ` Frank Li
2026-09-09  5:33     ` 回覆: " Billy Tsai
2026-09-09  5:33       ` Billy Tsai
2026-09-07  6:28   ` Krzysztof Kozlowski
2026-09-07  6:28     ` Krzysztof Kozlowski
2026-09-09  5:35     ` 回覆: " Billy Tsai
2026-09-09  5:35       ` Billy Tsai
2026-09-01 11:35 ` [PATCH 2/8] i3c: mipi-i3c-hci: Support address-indexed DAT slots Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:49   ` sashiko-bot [this message]
2026-09-01 11:49     ` sashiko-bot
2026-09-01 20:47   ` Frank Li
2026-09-01 20:47     ` Frank Li
2026-09-09  5:36     ` 回覆: " Billy Tsai
2026-09-09  5:36       ` Billy Tsai
2026-09-01 11:35 ` [PATCH 3/8] i3c: mipi-i3c-hci: Add a quirk for 64-bit DMA addressing Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:55   ` sashiko-bot
2026-09-01 11:55     ` sashiko-bot
2026-09-01 20:51   ` Frank Li
2026-09-01 20:51     ` Frank Li
2026-09-09  5:37     ` 回覆: " Billy Tsai
2026-09-09  5:37       ` Billy Tsai
2026-09-01 11:35 ` [PATCH 4/8] i3c: mipi-i3c-hci: Add a quirk to clear the TX start threshold Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:49   ` sashiko-bot
2026-09-01 11:49     ` sashiko-bot
2026-09-01 20:58   ` Frank Li
2026-09-01 20:58     ` Frank Li
2026-09-09  5:37     ` 回覆: " Billy Tsai
2026-09-09  5:37       ` Billy Tsai
2026-09-01 11:35 ` [PATCH 5/8] i3c: mipi-i3c-hci: Add support for the AST2700 I3C controller Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:52   ` sashiko-bot
2026-09-01 11:52     ` sashiko-bot
2026-09-01 21:18   ` Frank Li
2026-09-01 21:18     ` Frank Li
2026-09-09  5:38     ` 回覆: " Billy Tsai
2026-09-09  5:38       ` Billy Tsai
2026-09-01 11:35 ` [PATCH 6/8] i3c: mipi-i3c-hci: Program AST2700 IBI termination threshold Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:35 ` [PATCH 7/8] i3c: mipi-i3c-hci: Improve AST2700 PIO TX queue utilization Billy Tsai
2026-09-01 11:35   ` Billy Tsai
2026-09-01 11:51   ` sashiko-bot
2026-09-01 11:51     ` sashiko-bot
2026-09-01 11:35 ` [PATCH 8/8] i3c: mipi-i3c-hci: Support the AST2700 internal pull-ups Billy Tsai
2026-09-01 11:35   ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901114905.10CE71F00A3E@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=billy_tsai@aspeedtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.