All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: pbonzini@redhat.com, zhao1.liu@intel.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org,
	Daniil Tatianin <d-tatianin@yandex-team.ru>
Subject: Re: [PATCH] tests/../test_hotplug_blk: drop unused nic
Date: Tue, 1 Sep 2026 14:27:29 -0400	[thread overview]
Message-ID: <20260901182729.GA616149@fedora> (raw)
In-Reply-To: <20260629201332.1001055-1-vsementsov@yandex-team.ru>

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Mon, Jun 29, 2026 at 11:13:32PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> From: Daniil Tatianin <d-tatianin@yandex-team.ru>
> 
> The test doesn't need any networking, so drop the net card.
> Also the test will break if at some moment q35 aliase refers
> to machine type with default virtio-net nic, which will clash with
> virtio-blk in the test, and
> 
>    self.wait_for_console_pattern('virtio_blk virtio0: [vda]')
> 
> will not work.
> 
> Let's make the test a bit more resistant to experiments with
> machine type.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  tests/functional/x86_64/test_hotplug_blk.py | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2026-09-01 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 20:13 [PATCH] tests/../test_hotplug_blk: drop unused nic Vladimir Sementsov-Ogievskiy
2026-08-19 20:15 ` Vladimir Sementsov-Ogievskiy
2026-09-01 18:27 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901182729.GA616149@fedora \
    --to=stefanha@redhat.com \
    --cc=d-tatianin@yandex-team.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.