[PATCH] tests/../test_hotplug_blk: drop unused nic

[PATCH] tests/../test_hotplug_blk: drop unused nic

[Vladimir Sementsov-Ogievskiy]

From: Daniil Tatianin <d-tatianin@yandex-team.ru>

The test doesn't need any networking, so drop the net card.
Also the test will break if at some moment q35 aliase refers
to machine type with default virtio-net nic, which will clash with
virtio-blk in the test, and

   self.wait_for_console_pattern('virtio_blk virtio0: [vda]')

will not work.

Let's make the test a bit more resistant to experiments with
machine type.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 tests/functional/x86_64/test_hotplug_blk.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/functional/x86_64/test_hotplug_blk.py b/tests/functional/x86_64/test_hotplug_blk.py
index 7ddbfefc21..a9b43fe2e9 100755
--- a/tests/functional/x86_64/test_hotplug_blk.py
+++ b/tests/functional/x86_64/test_hotplug_blk.py
@@ -66,6 +66,7 @@ def test(self) -> None:
         self.set_machine('q35')
 
         self.vm.add_args('-accel', 'kvm')
+        self.vm.add_args("-nic", "none")  # avoid creating default nic
         self.vm.add_args('-device', 'pcie-pci-bridge,id=pci.1,bus=pcie.0')
         self.vm.add_args('-m', '1G')
         self.vm.add_args('-append', 'console=ttyS0 rd.rescue')
-- 
2.43.0

Re: [PATCH] tests/../test_hotplug_blk: drop unused nic

[Vladimir Sementsov-Ogievskiy]

ping

On 29.06.26 23:13, Vladimir Sementsov-Ogievskiy wrote:
> From: Daniil Tatianin <d-tatianin@yandex-team.ru>
> 
> The test doesn't need any networking, so drop the net card.
> Also the test will break if at some moment q35 aliase refers
> to machine type with default virtio-net nic, which will clash with
> virtio-blk in the test, and
> 
>     self.wait_for_console_pattern('virtio_blk virtio0: [vda]')
> 
> will not work.
> 
> Let's make the test a bit more resistant to experiments with
> machine type.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   tests/functional/x86_64/test_hotplug_blk.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/functional/x86_64/test_hotplug_blk.py b/tests/functional/x86_64/test_hotplug_blk.py
> index 7ddbfefc21..a9b43fe2e9 100755
> --- a/tests/functional/x86_64/test_hotplug_blk.py
> +++ b/tests/functional/x86_64/test_hotplug_blk.py
> @@ -66,6 +66,7 @@ def test(self) -> None:
>           self.set_machine('q35')
>   
>           self.vm.add_args('-accel', 'kvm')
> +        self.vm.add_args("-nic", "none")  # avoid creating default nic
>           self.vm.add_args('-device', 'pcie-pci-bridge,id=pci.1,bus=pcie.0')
>           self.vm.add_args('-m', '1G')
>           self.vm.add_args('-append', 'console=ttyS0 rd.rescue')


-- 
Best regards,
Vladimir

Re: [PATCH] tests/../test_hotplug_blk: drop unused nic

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Mon, Jun 29, 2026 at 11:13:32PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> From: Daniil Tatianin <d-tatianin@yandex-team.ru>
> 
> The test doesn't need any networking, so drop the net card.
> Also the test will break if at some moment q35 aliase refers
> to machine type with default virtio-net nic, which will clash with
> virtio-blk in the test, and
> 
>    self.wait_for_console_pattern('virtio_blk virtio0: [vda]')
> 
> will not work.
> 
> Let's make the test a bit more resistant to experiments with
> machine type.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  tests/functional/x86_64/test_hotplug_blk.py | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]