From: Kyle Hendry via B4 Relay <devnull+khendry.reliablecontrols.com@kernel.org>
To: "Clément Léger" <clement.leger@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kyle Hendry <khendry@reliablecontrols.com>
Subject: [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb
Date: Wed, 02 Sep 2026 11:37:36 -0700 [thread overview]
Message-ID: <20260902-rzn1-miic-fix-array-v3-2-3f7dccffaf5a@reliablecontrols.com> (raw)
In-Reply-To: <20260902-rzn1-miic-fix-array-v3-0-3f7dccffaf5a@reliablecontrols.com>
From: Kyle Hendry <khendry@reliablecontrols.com>
Add check to make sure port number is in range before writing
to dt_val array
Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c50b65d064fa..3ee40eb9d545 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -692,6 +692,12 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
if (of_property_read_u32(conv, "reg", &port))
continue;
+ if (port < miic->of_data->miic_port_start || port > miic->of_data->miic_port_max) {
+ dev_err(miic->dev, "Port number out of range: %d\n", port);
+ kfree(dt_val);
+ return -EINVAL;
+ }
+
if (of_property_read_u32(conv, "renesas,miic-input", &conf))
continue;
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Kyle Hendry <khendry@reliablecontrols.com>
To: "Clément Léger" <clement.leger@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kyle Hendry <khendry@reliablecontrols.com>
Subject: [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb
Date: Wed, 02 Sep 2026 11:37:36 -0700 [thread overview]
Message-ID: <20260902-rzn1-miic-fix-array-v3-2-3f7dccffaf5a@reliablecontrols.com> (raw)
In-Reply-To: <20260902-rzn1-miic-fix-array-v3-0-3f7dccffaf5a@reliablecontrols.com>
Add check to make sure port number is in range before writing
to dt_val array
Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c50b65d064fa..3ee40eb9d545 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -692,6 +692,12 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
if (of_property_read_u32(conv, "reg", &port))
continue;
+ if (port < miic->of_data->miic_port_start || port > miic->of_data->miic_port_max) {
+ dev_err(miic->dev, "Port number out of range: %d\n", port);
+ kfree(dt_val);
+ return -EINVAL;
+ }
+
if (of_property_read_u32(conv, "renesas,miic-input", &conf))
continue;
--
2.43.0
next prev parent reply other threads:[~2026-09-02 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 18:37 [PATCH v3 0/2] net: pcs: rzn1-miic: Fix config array initialization Kyle Hendry via B4 Relay
2026-09-02 18:37 ` Kyle Hendry
2026-09-02 18:37 ` [PATCH v3 1/2] " Kyle Hendry via B4 Relay
2026-09-02 18:37 ` Kyle Hendry
2026-09-07 19:26 ` Lad, Prabhakar
2026-09-02 18:37 ` Kyle Hendry via B4 Relay [this message]
2026-09-02 18:37 ` [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry
2026-09-02 18:50 ` Andrew Lunn
2026-09-02 22:12 ` Jakub Kicinski
2026-09-07 19:39 ` Lad, Prabhakar
2026-09-07 20:49 ` Andrew Lunn
2026-09-07 21:23 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902-rzn1-miic-fix-array-v3-2-3f7dccffaf5a@reliablecontrols.com \
--to=devnull+khendry.reliablecontrols.com@kernel.org \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=khendry@reliablecontrols.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.