All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/2] fix a leak in submodule error path
Date: Wed, 2 Sep 2026 01:51:17 -0400	[thread overview]
Message-ID: <20260902055117.GA41587@coredump.intra.peff.net> (raw)

This fixes a small leak noticed by Coverity. I think it has been there
for a while, but nearby code movement caused it to be marked as "new".

  [1/2]: repository: make repo_clear() idempotent
  [2/2]: submodule--helper: free URL when repository setup fails

 builtin/submodule--helper.c             | 10 +++++++---
 repository.c                            |  3 ++-
 t/t7426-submodule-get-default-remote.sh | 17 +++++++++++++++++
 3 files changed, 26 insertions(+), 4 deletions(-)

-Peff

             reply	other threads:[~2026-09-02  5:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  5:51 Jeff King [this message]
2026-09-02  5:55 ` [PATCH 1/2] repository: make repo_clear() idempotent Jeff King
2026-09-02  6:29   ` Jeff King
2026-09-02  6:49     ` Jeff King
2026-09-02  9:11       ` Patrick Steinhardt
2026-09-02 16:29         ` Junio C Hamano
2026-09-03  5:15           ` Patrick Steinhardt
2026-09-02  5:57 ` [PATCH 2/2] submodule--helper: free URL when repository setup fails Jeff King
2026-09-02  9:11   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902055117.GA41587@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.