All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Subject: Re: [PATCH 1/2] repository: make repo_clear() idempotent
Date: Wed, 02 Sep 2026 09:29:48 -0700	[thread overview]
Message-ID: <xmqqpkyvk45f.fsf@gitster.g> (raw)
In-Reply-To: <apfoNaZL8dg9OpbL@pks.im> (Patrick Steinhardt's message of "Wed, 2 Sep 2026 11:11:17 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> I was at one point wondering whether the parsed object pool should
> really be an implementation detail of the object database -- parsing
> objects should not have to depend on the repository, ...

We need to be a bit careful here, as the above directly contradicts
our earlier design choice to have things like hash algorithm as
properties of a repository instance.

> This would eventually ensure that our subsystems are more self-contained 
> and that they can be used more flexibly.

I do agree with this line of thinking, though.

Thanks.

  reply	other threads:[~2026-09-02 16:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  5:51 [PATCH 0/2] fix a leak in submodule error path Jeff King
2026-09-02  5:55 ` [PATCH 1/2] repository: make repo_clear() idempotent Jeff King
2026-09-02  6:29   ` Jeff King
2026-09-02  6:49     ` Jeff King
2026-09-02  9:11       ` Patrick Steinhardt
2026-09-02 16:29         ` Junio C Hamano [this message]
2026-09-03  5:15           ` Patrick Steinhardt
2026-09-02  5:57 ` [PATCH 2/2] submodule--helper: free URL when repository setup fails Jeff King
2026-09-02  9:11   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpkyvk45f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.