From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
git@vger.kernel.org
Subject: [PATCH 0/2] bump ci asciidoctor version
Date: Wed, 2 Sep 2026 03:11:13 -0400 [thread overview]
Message-ID: <20260902071113.GA70165@coredump.intra.peff.net> (raw)
In-Reply-To: <aparyEbGiiFZpiCZ@pks.im>
On Tue, Sep 01, 2026 at 12:41:12PM +0200, Patrick Steinhardt wrote:
> > But these days I'd guess everybody is using v2.0.x (which seems to work
> > fine) for local builds. We probably ought to do the same in CI. If we
> > have to catch issues in one, I'd rather it be the one people are likely
> > to actually use.
>
> > It's possible that we could benefit from building with both in order to
> > support the older version. But given its age I doubt it's worth it. We
> > can still take bug fixes if somebody finds a problem, but we don't
> > necessarily need to spend cycles building every commit with 1.5.8.
>
> I was wondering about whether I should bump its version while at it. In
> fact, we could just install it from the Ubuntu sources nowadays, too. I
> ultimately decided to not do that though and just fix the failing CI
> pipeline for now, but I agree that it's something we might want to
> follow up on.
I think your fix kept to the minimum, which is good. I agree we should
just install it from the system package manager. I _thought_ that might
make your fix here obsolete, but we also install the concurrent-ruby
gem. That comes from 974cdca345 (doc: introduce a synopsis typesetting,
2024-09-24) which also introduced some custom ruby code in asciidoctor
extensions. But it's not clear to me why it's necessary (and I build the
docs happily on my local system without it installed). +cc Jean-Noël for
any wisdom.
I guess installing asciidoctor from Ubuntu would also bring in ruby as a
dependency. So I suppose it does make your patch obsolete, but it also
doesn't hurt to be explicit that we expect "gem install" to work.
Anyway, here is a fix for the version which can be applied on top of
ps/ci-depends-on-ruby.
-Peff
next prev parent reply other threads:[~2026-09-02 7:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:16 [PATCH] ci: fix missing Ruby dependency in "documentation" job Patrick Steinhardt
2026-09-01 8:24 ` Toon Claes
2026-09-01 8:36 ` Patrick Steinhardt
2026-09-01 8:47 ` Jeff King
2026-09-01 8:51 ` Jeff King
2026-09-01 10:41 ` Patrick Steinhardt
2026-09-02 7:11 ` Jeff King [this message]
2026-09-02 7:14 ` [PATCH 1/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable Jeff King
2026-09-02 7:16 ` [PATCH 2/2] ci: use system asciidoctor Jeff King
2026-09-02 7:55 ` Patrick Steinhardt
2026-09-02 9:01 ` Jeff King
2026-09-02 9:59 ` Patrick Steinhardt
2026-09-05 14:02 ` Jeff King
2026-09-05 15:23 ` Todd Zullinger
2026-09-11 20:42 ` Jeff King
2026-09-11 19:52 ` [PATCH (RESEND)] " Tuomas Ahola
2026-09-11 20:38 ` Jeff King
2026-09-11 20:58 ` Junio C Hamano
2026-09-11 21:33 ` Tuomas Ahola
2026-09-11 21:50 ` Junio C Hamano
2026-09-01 17:58 ` [PATCH] ci: fix missing Ruby dependency in "documentation" job Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902071113.GA70165@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.