All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Tuomas Ahola <taahol@utu.fi>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Jean-Noël Avila" <jn.avila@free.fr>
Subject: Re: [PATCH (RESEND)] ci: use system asciidoctor
Date: Fri, 11 Sep 2026 16:38:07 -0400	[thread overview]
Message-ID: <20260911203807.GA1622087@coredump.intra.peff.net> (raw)
In-Reply-To: <20260911195250.31201-1-taahol@utu.fi>

On Fri, Sep 11, 2026 at 10:52:50PM +0300, Tuomas Ahola wrote:

>     The release notes draft for v2.56.0 already claims that asciidoctor
>     has been updated to be installed via the system package manager.
>     Clearly it refers to this patch which isn't, however, anywhere near
>     the master branch.

I was confused about what was going on from this description, and why
patch 1/2 is not mentioned here. But reading the "What's cooking"
conversation, I think it is simply: this patch was missed when picking
up the jk/ci-use-system-asciidoctor topic.

Possibly because the lead-in patch from Patrick got duplicated (I notice
that jk/ci-use-system-asciidoctor is not based on ps/ci-depends-on-ruby).
But whatever the reason, this was supposed to go on top of the jk/
topic branch.

Thanks for noticing.

-Peff

  reply	other threads:[~2026-09-11 20:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  8:16 [PATCH] ci: fix missing Ruby dependency in "documentation" job Patrick Steinhardt
2026-09-01  8:24 ` Toon Claes
2026-09-01  8:36   ` Patrick Steinhardt
2026-09-01  8:47 ` Jeff King
2026-09-01  8:51   ` Jeff King
2026-09-01 10:41   ` Patrick Steinhardt
2026-09-02  7:11     ` [PATCH 0/2] bump ci asciidoctor version Jeff King
2026-09-02  7:14       ` [PATCH 1/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable Jeff King
2026-09-02  7:16       ` [PATCH 2/2] ci: use system asciidoctor Jeff King
2026-09-02  7:55         ` Patrick Steinhardt
2026-09-02  9:01           ` Jeff King
2026-09-02  9:59             ` Patrick Steinhardt
2026-09-05 14:02               ` Jeff King
2026-09-05 15:23                 ` Todd Zullinger
2026-09-11 20:42                   ` Jeff King
2026-09-11 19:52       ` [PATCH (RESEND)] " Tuomas Ahola
2026-09-11 20:38         ` Jeff King [this message]
2026-09-11 20:58         ` Junio C Hamano
2026-09-11 21:33           ` Tuomas Ahola
2026-09-11 21:50             ` Junio C Hamano
2026-09-01 17:58   ` [PATCH] ci: fix missing Ruby dependency in "documentation" job Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911203807.GA1622087@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jn.avila@free.fr \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.