All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: mfd@lists.linux.dev, lee@kernel.org, conor+dt@kernel.org,
	robh@kernel.org, devicetree@vger.kernel.org,
	linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org
Subject: Re: [PATCH v11 4/6] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support
Date: Wed, 02 Sep 2026 13:13:53 +0000	[thread overview]
Message-ID: <20260902131354.197C61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-add-mcu-fan-khadas-vim4-v11-4-5f1610d83bf0@aliel.fr>

> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> Read the fan register and level table from platform_data (fan_reg,
> levels[] and nlevels) instead of hardcoding a single register and
> level count, as new MCUs need different values. MAX_LEVEL is kept
> and bumped from 3 to 5 to make the speed change more gradual with
> the newer MCUs.
> 
> The cooling device's state is stored as an index into levels[],
> and khadas_mcu_fan_set_level() writes levels[state] to fan_reg,
> rather than writing the raw state value as before.
> 
> Optionally acquire and enable a "fan" regulator supply
> at probe time and on resume,
> so boards that gate fan power through a regulator are handled.
> The regulator is released via a devm_add_action_or_reset()
> callback.
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-add-mcu-fan-khadas-vim4-v11-0-5f1610d83bf0@aliel.fr?part=4


WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: mfd@lists.linux.dev, lee@kernel.org, conor+dt@kernel.org,
	robh@kernel.org, devicetree@vger.kernel.org,
	linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org
Subject: Re: [PATCH v11 4/6] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support
Date: Wed, 02 Sep 2026 13:13:53 +0000	[thread overview]
Message-ID: <20260902131354.197C61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-add-mcu-fan-khadas-vim4-v11-4-5f1610d83bf0@aliel.fr>

> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> Read the fan register and level table from platform_data (fan_reg,
> levels[] and nlevels) instead of hardcoding a single register and
> level count, as new MCUs need different values. MAX_LEVEL is kept
> and bumped from 3 to 5 to make the speed change more gradual with
> the newer MCUs.
> 
> The cooling device's state is stored as an index into levels[],
> and khadas_mcu_fan_set_level() writes levels[state] to fan_reg,
> rather than writing the raw state value as before.
> 
> Optionally acquire and enable a "fan" regulator supply
> at probe time and on resume,
> so boards that gate fan power through a regulator are handled.
> The regulator is released via a devm_add_action_or_reset()
> callback.
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-add-mcu-fan-khadas-vim4-v11-0-5f1610d83bf0@aliel.fr?part=4


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-09-02 13:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 12:51 [PATCH v11 0/6] Add VIM4 MCU/FAN support Ronald Claveau via B4 Relay
2026-09-02 12:51 ` Ronald Claveau
2026-09-02 12:51 ` Ronald Claveau via B4 Relay
2026-09-02 12:51 ` [PATCH v11 1/6] mfd: khadas-mcu: Add per-variant configuration infrastructure and VIM4 support Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 13:02   ` sashiko-bot
2026-09-02 13:02     ` sashiko-bot
2026-09-10 14:16     ` Lee Jones
2026-09-10 14:16       ` Lee Jones
2026-09-02 12:51 ` [PATCH v11 2/6] mfd: khadas-mcu: Use MFD_CELL_* macros for cell declarations Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 12:58   ` sashiko-bot
2026-09-02 12:58     ` sashiko-bot
2026-09-02 12:51 ` [PATCH v11 3/6] mfd: khadas-mcu: Add support for VIM4 MCU variant Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 13:04   ` sashiko-bot
2026-09-02 13:04     ` sashiko-bot
2026-09-10 14:21   ` Lee Jones
2026-09-10 14:21     ` Lee Jones
2026-09-02 12:51 ` [PATCH v11 4/6] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 13:13   ` sashiko-bot [this message]
2026-09-02 13:13     ` sashiko-bot
2026-09-02 12:51 ` [PATCH v11 5/6] arm64: dts: amlogic: t7: Add i2c controller node Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 13:05   ` sashiko-bot
2026-09-02 13:05     ` sashiko-bot
2026-09-02 12:51 ` [PATCH v11 6/6] arm64: dts: amlogic: t7: khadas-vim4: Add i2c MCU fan node Ronald Claveau via B4 Relay
2026-09-02 12:51   ` Ronald Claveau
2026-09-02 12:51   ` Ronald Claveau via B4 Relay
2026-09-02 13:06   ` sashiko-bot
2026-09-02 13:06     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902131354.197C61F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=mfd@lists.linux.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.