From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org
Subject: Re: [PATCH RESEND] xor: add missing vzeroupper to AVX code
Date: Wed, 2 Sep 2026 15:37:06 +0200 [thread overview]
Message-ID: <20260902133706.GA21538@lst.de> (raw)
In-Reply-To: <20260831212248.213805-1-ebiggers@kernel.org>
On Mon, Aug 31, 2026 at 02:22:48PM -0700, Eric Biggers wrote:
> Since the AVX optimized XOR code uses YMM registers, execute vzeroupper
> before returning from it. This is needed to avoid degrading the
> performance of any later SSE code that may happen to be executed.
>
> Fixes: ea4d26ae24e5 ("raid5: add AVX optimized RAID5 checksumming")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This didn't get taken through the x86 tree. Andrew, it seems you're
> taking patches to lib/raid/. Can you apply this one?
Can we do kernel_avx_{begin,end} instead of having to open code
and document this everywhere, please?
next prev parent reply other threads:[~2026-09-02 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 21:22 [PATCH RESEND] xor: add missing vzeroupper to AVX code Eric Biggers
2026-08-31 22:06 ` sashiko-bot
2026-08-31 22:09 ` Eric Biggers
2026-09-02 13:37 ` Christoph Hellwig [this message]
2026-09-02 16:07 ` David Laight
2026-09-02 16:23 ` Eric Biggers
2026-09-02 18:19 ` David Laight
2026-09-02 18:41 ` Eric Biggers
2026-09-03 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902133706.GA21538@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.