All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ext4, doc: remove unnecessary bracket
@ 2026-09-02 14:32 Manuel Ebner
  2026-09-02 14:35 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Manuel Ebner @ 2026-09-02 14:32 UTC (permalink / raw)
  To: Theodore Ts'o, Andreas Dilger, Baokun Li, Jan Kara,
	Ojaswin Mujoo, Ritesh Harjani (IBM), Zhang Yi, Jonathan Corbet,
	Shuah Khan
  Cc: Manuel Ebner, linux-ext4, linux-doc, linux-kernel

Remove needless '('.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
 Documentation/filesystems/ext4/directory.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/ext4/directory.rst b/Documentation/filesystems/ext4/directory.rst
index 9b003a4d4..f3eeca844 100644
--- a/Documentation/filesystems/ext4/directory.rst
+++ b/Documentation/filesystems/ext4/directory.rst
@@ -429,7 +429,7 @@ block (precisely the length of one dx_entry) are used to store a
 ``count`` entries in the dx_root/dx_node structures are adjusted as
 necessary to fit the dx_tail into the block. If there is no space for
 the dx_tail, the user is notified to run e2fsck -D to rebuild the
-directory index (which will ensure that there's space for the checksum.
+directory index which will ensure that there's space for the checksum.
 The dx_tail structure is 8 bytes long and looks like this:
 
 .. list-table::
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ext4, doc: remove unnecessary bracket
  2026-09-02 14:32 [PATCH] ext4, doc: remove unnecessary bracket Manuel Ebner
@ 2026-09-02 14:35 ` sashiko-bot
  2026-09-02 14:59 ` Jan Kara
  2026-09-02 17:31 ` Randy Dunlap
  2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-02 14:35 UTC (permalink / raw)
  To: Manuel Ebner; +Cc: tytso, linux-ext4

> Remove needless '('.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902143254.702971-2-manuelebnerli@mailbox.org?part=1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ext4, doc: remove unnecessary bracket
  2026-09-02 14:32 [PATCH] ext4, doc: remove unnecessary bracket Manuel Ebner
  2026-09-02 14:35 ` sashiko-bot
@ 2026-09-02 14:59 ` Jan Kara
  2026-09-02 17:31 ` Randy Dunlap
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2026-09-02 14:59 UTC (permalink / raw)
  To: Manuel Ebner
  Cc: Theodore Ts'o, Andreas Dilger, Baokun Li, Jan Kara,
	Ojaswin Mujoo, Ritesh Harjani (IBM), Zhang Yi, Jonathan Corbet,
	Shuah Khan, linux-ext4, linux-doc, linux-kernel

On Wed 02-09-26 16:32:53, Manuel Ebner wrote:
> Remove needless '('.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Sure. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/filesystems/ext4/directory.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/ext4/directory.rst b/Documentation/filesystems/ext4/directory.rst
> index 9b003a4d4..f3eeca844 100644
> --- a/Documentation/filesystems/ext4/directory.rst
> +++ b/Documentation/filesystems/ext4/directory.rst
> @@ -429,7 +429,7 @@ block (precisely the length of one dx_entry) are used to store a
>  ``count`` entries in the dx_root/dx_node structures are adjusted as
>  necessary to fit the dx_tail into the block. If there is no space for
>  the dx_tail, the user is notified to run e2fsck -D to rebuild the
> -directory index (which will ensure that there's space for the checksum.
> +directory index which will ensure that there's space for the checksum.
>  The dx_tail structure is 8 bytes long and looks like this:
>  
>  .. list-table::
> -- 
> 2.54.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ext4, doc: remove unnecessary bracket
  2026-09-02 14:32 [PATCH] ext4, doc: remove unnecessary bracket Manuel Ebner
  2026-09-02 14:35 ` sashiko-bot
  2026-09-02 14:59 ` Jan Kara
@ 2026-09-02 17:31 ` Randy Dunlap
  2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-09-02 17:31 UTC (permalink / raw)
  To: Manuel Ebner, Theodore Ts'o, Andreas Dilger, Baokun Li,
	Jan Kara, Ojaswin Mujoo, Ritesh Harjani (IBM), Zhang Yi,
	Jonathan Corbet, Shuah Khan
  Cc: linux-ext4, linux-doc, linux-kernel



On 9/2/26 7:32 AM, Manuel Ebner wrote:
> Remove needless '('.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
>  Documentation/filesystems/ext4/directory.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/ext4/directory.rst b/Documentation/filesystems/ext4/directory.rst
> index 9b003a4d4..f3eeca844 100644
> --- a/Documentation/filesystems/ext4/directory.rst
> +++ b/Documentation/filesystems/ext4/directory.rst
> @@ -429,7 +429,7 @@ block (precisely the length of one dx_entry) are used to store a
>  ``count`` entries in the dx_root/dx_node structures are adjusted as
>  necessary to fit the dx_tail into the block. If there is no space for
>  the dx_tail, the user is notified to run e2fsck -D to rebuild the
> -directory index (which will ensure that there's space for the checksum.
> +directory index which will ensure that there's space for the checksum.

To me, it needs either a closing parenthesis or a comma, like:

   directory index, which will ensure

>  The dx_tail structure is 8 bytes long and looks like this:
>  
>  .. list-table::

-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-02 17:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02 14:32 [PATCH] ext4, doc: remove unnecessary bracket Manuel Ebner
2026-09-02 14:35 ` sashiko-bot
2026-09-02 14:59 ` Jan Kara
2026-09-02 17:31 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.