[PATCH] generic/795: add missing _require_scratch check

[PATCH] generic/795: add missing _require_scratch check

[Prabhakar Pujeri]

The test runs _scratch_mkfs and _scratch_mount without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 tests/generic/795 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/generic/795 b/tests/generic/795
index fa5474c5..4c0e7bdb 100755
--- a/tests/generic/795
+++ b/tests/generic/795
@@ -27,6 +27,8 @@ _cleanup()
 
 . ./common/filter
 
+_require_scratch
+
 fsv_file_size=10000000
 nproc_enabler=$((4 * LOAD_FACTOR))
 nproc_reader=$((6 * LOAD_FACTOR))
-- 
2.55.0

Re: [PATCH] generic/795: add missing _require_scratch check

[Darrick J. Wong]

On Wed, Sep 02, 2026 at 05:01:39AM +0000, Prabhakar Pujeri wrote:
> The test runs _scratch_mkfs and _scratch_mount without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>

Looks ok, though if you're going to write more of these patches you
might want to put them all under a single patchset...

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/795 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/generic/795 b/tests/generic/795
> index fa5474c5..4c0e7bdb 100755
> --- a/tests/generic/795
> +++ b/tests/generic/795
> @@ -27,6 +27,8 @@ _cleanup()
>  
>  . ./common/filter
>  
> +_require_scratch
> +
>  fsv_file_size=10000000
>  nproc_enabler=$((4 * LOAD_FACTOR))
>  nproc_reader=$((6 * LOAD_FACTOR))
> -- 
> 2.55.0
> 
> 

Re: [PATCH] generic/795: add missing _require_scratch check

[Zorro Lang]

On Wed, Sep 02, 2026 at 08:13:16AM -0700, Darrick J. Wong wrote:
> On Wed, Sep 02, 2026 at 05:01:39AM +0000, Prabhakar Pujeri wrote:
> > The test runs _scratch_mkfs and _scratch_mount without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured.
> > 
> > Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> 
> Looks ok, though if you're going to write more of these patches you
> might want to put them all under a single patchset...

Yes, I've locally merged your 3 patches that add _require_scratch:

  btrfs/333: require scratch before checking encoded reads
  overlay/081: add missing _require_scratch check
  btrfs/273: add missing _require_scratch check

Are you still working on this progress? If so please consider sending them as a
single patch or unified patchset so I don't have to pick them piecemeal.

If there are no more, I'll just merge this one with the other three :)

Thanks,
Zorro

> 
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> --D
> 
> > ---
> >  tests/generic/795 | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tests/generic/795 b/tests/generic/795
> > index fa5474c5..4c0e7bdb 100755
> > --- a/tests/generic/795
> > +++ b/tests/generic/795
> > @@ -27,6 +27,8 @@ _cleanup()
> >  
> >  . ./common/filter
> >  
> > +_require_scratch
> > +
> >  fsv_file_size=10000000
> >  nproc_enabler=$((4 * LOAD_FACTOR))
> >  nproc_reader=$((6 * LOAD_FACTOR))
> > -- 
> > 2.55.0
> > 
> >