All of lore.kernel.org
 help / color / mirror / Atom feed
From: Melissa Wen <mwen@igalia.com>
To: Petri Latvala <adrinael@adrinael.net>,
	Arkadiusz Hiler <arek@hiler.eu>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
	Ashutosh Dixit <ashutosh.dixit@intel.com>,
	Karthik B S <karthik.b.s@intel.com>
Cc: igt-dev@lists.freedesktop.org, kernel-dev@igalia.com,
	Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	Alex Hung <alex.hung@amd.com>,
	Swati Sharma <swati2.sharma@intel.com>,
	John Harrison <John.Harrison@Igalia.com>,
	Rodrigo Siqueira <siqueira@igalia.com>,
	Simon Ser <contact@emersion.fr>, Xaver Hugl <xaver.hugl@kde.org>,
	Harry Wentland <harry.wentland@amd.com>,
	Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH i-g-t v5 7/8] tests/intel/kms_color_pipeline: move driver-specific test to intel's folder
Date: Wed,  2 Sep 2026 19:58:07 +0200	[thread overview]
Message-ID: <20260902180016.303482-8-mwen@igalia.com> (raw)
In-Reply-To: <20260902180016.303482-1-mwen@igalia.com>

As stated in test docs, the kms_color_pipeline isn't driver-agnostic. It
validates color transformations using CRC, which is less accurate than
comparing writeback buffers, but the i915 and xe drivers require CRC
validation when the writeback connector is not supported: kms_colorop
tests don't run when writeback is not supported. Since other drivers
that support colorops also support writeback, this CRC option is
currently only required by Intel; therefore, move kms_color_pipeline
test to the Intel folder and only open Intel's drivers (not any).

If the CRC-based colorop test is useful for some other driver, the
required generalizations and switch to the common folder should be made.

Signed-off-by: Melissa Wen <mwen@igalia.com>
---
 tests/{ => intel}/kms_color_pipeline.c | 2 +-
 tests/meson.build                      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename tests/{ => intel}/kms_color_pipeline.c (99%)

diff --git a/tests/kms_color_pipeline.c b/tests/intel/kms_color_pipeline.c
similarity index 99%
rename from tests/kms_color_pipeline.c
rename to tests/intel/kms_color_pipeline.c
index f71416ce1..3d41b811b 100644
--- a/tests/kms_color_pipeline.c
+++ b/tests/intel/kms_color_pipeline.c
@@ -353,7 +353,7 @@ int igt_main()
 	data_t data = {};
 
 	igt_fixture() {
-		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 
 		/*
 		 * Plane color pipeline support requires atomic modesetting.
diff --git a/tests/meson.build b/tests/meson.build
index 1ac89bab7..c1a436420 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -25,7 +25,6 @@ test_progs = [
 	'kms_atomic_transition',
 	'kms_bw',
 	'kms_color',
-	'kms_color_pipeline',
 	'kms_concurrent',
 	'kms_colorop',
 	'kms_content_protection',
@@ -250,6 +249,7 @@ intel_kms_progs = [
 	'kms_busy',
 	'kms_ccs',
 	'kms_cdclk',
+	'kms_color_pipeline',
 	'kms_dirtyfb',
 	'kms_dp_link_training',
         'kms_dp_linktrain_fallback',
-- 
2.53.0


  parent reply	other threads:[~2026-09-02 18:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 17:58 [PATCH i-g-t v5 0/8] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 1/8] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 2/8] tests/kms_colorop_helper: only check if a given enum value exists Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 3/8] tests/kms_properties: don't check colorop if no plane color pipeline prop Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 4/8] tests/kms_properties: give non-primary planes their own fb Melissa Wen
2026-09-30 16:06   ` Harry Wentland
2026-09-30 19:37     ` Melissa Wen
2026-09-30 21:02       ` Harry Wentland
2026-09-02 17:58 ` [PATCH i-g-t v5 5/8] lib/igt_kms: extend igt_plane_set_color_pipeline to accept Bypass Melissa Wen
2026-09-09  7:54   ` Borah, Chaitanya Kumar
2026-09-30 15:43   ` Harry Wentland
2026-09-02 17:58 ` [PATCH i-g-t v5 6/8] tests/kms_properties: check colorop properties on active color pipelines Melissa Wen
2026-09-09  7:55   ` Borah, Chaitanya Kumar
2026-09-30 15:44   ` Harry Wentland
2026-09-02 17:58 ` Melissa Wen [this message]
2026-09-08 19:17   ` [PATCH i-g-t v5 7/8] tests/intel/kms_color_pipeline: move driver-specific test to intel's folder Sharma, Swati2
2026-09-09  7:56   ` Borah, Chaitanya Kumar
2026-09-30 15:45   ` Harry Wentland
2026-09-02 17:58 ` [PATCH i-g-t v5 8/8] lib/igt_kms: add macros to iterate color pipelines and colorops Melissa Wen
2026-09-03 10:44   ` Jani Nikula
2026-09-09  8:31     ` Jani Nikula
2026-09-09  7:56   ` Borah, Chaitanya Kumar
2026-09-02 23:19 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely (rev3) Patchwork
2026-09-02 23:22 ` ✗ i915.CI.BAT: failure " Patchwork
2026-09-03 15:30 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902180016.303482-8-mwen@igalia.com \
    --to=mwen@igalia.com \
    --cc=John.Harrison@Igalia.com \
    --cc=adrinael@adrinael.net \
    --cc=alex.hung@amd.com \
    --cc=arek@hiler.eu \
    --cc=ashutosh.dixit@intel.com \
    --cc=bhanuprakash.modem@gmail.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=contact@emersion.fr \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=kernel-dev@igalia.com \
    --cc=siqueira@igalia.com \
    --cc=swati2.sharma@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=xaver.hugl@kde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.