Re: [PATCH i-g-t v5 7/8] tests/intel/kms_color_pipeline: move driver-specific test to intel's folder

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 9/2/2026 11:28 PM, Melissa Wen wrote:
> As stated in test docs, the kms_color_pipeline isn't driver-agnostic. It
> validates color transformations using CRC, which is less accurate than
> comparing writeback buffers, but the i915 and xe drivers require CRC
> validation when the writeback connector is not supported: kms_colorop
> tests don't run when writeback is not supported. Since other drivers
> that support colorops also support writeback, this CRC option is
> currently only required by Intel; therefore, move kms_color_pipeline
> test to the Intel folder and only open Intel's drivers (not any).
> 
> If the CRC-based colorop test is useful for some other driver, the
> required generalizations and switch to the common folder should be made.
> 

LGTM

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
>   tests/{ => intel}/kms_color_pipeline.c | 2 +-
>   tests/meson.build                      | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>   rename tests/{ => intel}/kms_color_pipeline.c (99%)
> 
> diff --git a/tests/kms_color_pipeline.c b/tests/intel/kms_color_pipeline.c
> similarity index 99%
> rename from tests/kms_color_pipeline.c
> rename to tests/intel/kms_color_pipeline.c
> index f71416ce1..3d41b811b 100644
> --- a/tests/kms_color_pipeline.c
> +++ b/tests/intel/kms_color_pipeline.c
> @@ -353,7 +353,7 @@ int igt_main()
>   	data_t data = {};
>   
>   	igt_fixture() {
> -		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> +		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
>   
>   		/*
>   		 * Plane color pipeline support requires atomic modesetting.
> diff --git a/tests/meson.build b/tests/meson.build
> index 1ac89bab7..c1a436420 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -25,7 +25,6 @@ test_progs = [
>   	'kms_atomic_transition',
>   	'kms_bw',
>   	'kms_color',
> -	'kms_color_pipeline',
>   	'kms_concurrent',
>   	'kms_colorop',
>   	'kms_content_protection',
> @@ -250,6 +249,7 @@ intel_kms_progs = [
>   	'kms_busy',
>   	'kms_ccs',
>   	'kms_cdclk',
> +	'kms_color_pipeline',
>   	'kms_dirtyfb',
>   	'kms_dp_link_training',
>           'kms_dp_linktrain_fallback',