drivers/platform/x86/classmate-laptop.c:1033 cmpc_ipml_probe() warn: 'ipml->rf' is an error pointer or valid

drivers/platform/x86/classmate-laptop.c:1033 cmpc_ipml_probe() warn: 'ipml->rf' is an error pointer or valid

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   89a312991dc6e638a36adc43ccb91dbc25504c04
commit: 069b06f8dfc9821fa54f0c5109ebbde891ea363a platform/x86: classmate-laptop: Convert ipml driver to a platform one
date:   4 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 4 months ago
config: i386-randconfig-141-20260902 (https://download.01.org/0day-ci/archive/20260902/202609022215.3KRQQCGe-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 069b06f8dfc9 ("platform/x86: classmate-laptop: Convert ipml driver to a platform one")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609022215.3KRQQCGe-lkp@intel.com/

smatch warnings:
drivers/platform/x86/classmate-laptop.c:1033 cmpc_ipml_probe() warn: 'ipml->rf' is an error pointer or valid

vim +1033 drivers/platform/x86/classmate-laptop.c

d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27   999  
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1000  static int cmpc_ipml_probe(struct platform_device *pdev)
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1001  {
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1002  	int retval;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1003  	struct ipml200_dev *ipml;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1004  	struct backlight_properties props;
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1005  	acpi_handle handle;
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1006  
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1007  	handle = ACPI_HANDLE(&pdev->dev);
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1008  	if (!handle)
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1009  		return -ENODEV;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1010  
bf4afc53b77aeaa Linus Torvalds                2026-02-21  1011  	ipml = kmalloc_obj(*ipml);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1012  	if (ipml == NULL)
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1013  		return -ENOMEM;
529aa8cb0a59367 Thadeu Lima de Souza Cascardo 2009-12-21  1014  
a19a6ee6cad2b20 Matthew Garrett               2010-02-17  1015  	memset(&props, 0, sizeof(struct backlight_properties));
bb7ca747f8d6243 Matthew Garrett               2011-03-22  1016  	props.type = BACKLIGHT_PLATFORM;
a19a6ee6cad2b20 Matthew Garrett               2010-02-17  1017  	props.max_brightness = 7;
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1018  	ipml->bd = backlight_device_register("cmpc_bl", &pdev->dev,
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1019  					     handle, &cmpc_bl_ops,
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1020  					     &props);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1021  	if (IS_ERR(ipml->bd)) {
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1022  		retval = PTR_ERR(ipml->bd);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1023  		goto out_bd;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1024  	}
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1025  
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1026  	ipml->rf = rfkill_alloc("cmpc_rfkill", &pdev->dev, RFKILL_TYPE_WLAN,
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1027  				&cmpc_rfkill_ops, handle);
b95d13eaf3d4ea0 Thadeu Lima de Souza Cascardo 2010-06-09  1028  	/*
b95d13eaf3d4ea0 Thadeu Lima de Souza Cascardo 2010-06-09  1029  	 * If RFKILL is disabled, rfkill_alloc will return ERR_PTR(-ENODEV).
b95d13eaf3d4ea0 Thadeu Lima de Souza Cascardo 2010-06-09  1030  	 * This is OK, however, since all other uses of the device will not
3b329cfec7522b5 Bhaskar Chowdhury             2021-03-17  1031  	 * dereference it.
b95d13eaf3d4ea0 Thadeu Lima de Souza Cascardo 2010-06-09  1032  	 */
b95d13eaf3d4ea0 Thadeu Lima de Souza Cascardo 2010-06-09 @1033  	if (ipml->rf) {
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1034  		retval = rfkill_register(ipml->rf);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1035  		if (retval) {
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1036  			rfkill_destroy(ipml->rf);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1037  			ipml->rf = NULL;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1038  		}
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1039  	}
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1040  
069b06f8dfc9821 Rafael J. Wysocki             2026-05-11  1041  	platform_set_drvdata(pdev, ipml);
529aa8cb0a59367 Thadeu Lima de Souza Cascardo 2009-12-21  1042  	return 0;
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1043  
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1044  out_bd:
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1045  	kfree(ipml);
d5c051f1080e0ee Thadeu Lima de Souza Cascardo 2010-04-27  1046  	return retval;
529aa8cb0a59367 Thadeu Lima de Souza Cascardo 2009-12-21  1047  }
529aa8cb0a59367 Thadeu Lima de Souza Cascardo 2009-12-21  1048  

:::::: The code at line 1033 was first introduced by commit
:::::: b95d13eaf3d4ea093aba95c7f615f3b10708a2c4 classmate-laptop: should check for NULL as retval for rfkill_alloc

:::::: TO: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
:::::: CC: Matthew Garrett <mjg@redhat.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki