All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support
@ 2026-09-03  7:18 Khalid Faisal Ansari
  2026-09-03  7:18 ` [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17 Khalid Faisal Ansari
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Khalid Faisal Ansari @ 2026-09-03  7:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Khalid Faisal Ansari,
	Konrad Dybcio

The Shikra EVK platforms support an ST33 TPM connected over SPI5.

This series first removes GPIOs 14-17 from the reserved ranges so 
that SPI5 can be used by Linux, and then enables the ST33 TPM in
the common Shikra EVK device tree.

Changes in v5:
- Add Reviewed-by tag from Konrad Dybcio for v4-patch 1.
- Keep node references in alphabetical order.

Link to v4: https://lore.kernel.org/r/20260826-shikra-dtpm-v4-0-8476223184de@oss.qualcomm.com

Changes in v4:
  - Send the interdependent GPIO and TPM changes together.
  - Add the SPI5 and TPM nodes to shikra-evk.dtsi.
  - Remove GPIOs 14-17 from the reserved ranges.

Link to v3: https://lore.kernel.org/all/20260820-shikra_dtpm-v3-1-93cdd4f3e8dc@oss.qualcomm.com/

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
---
Khalid Faisal Ansari (2):
      arm64: dts: qcom: shikra: unreserve GPIOs 14-17
      arm64: dts: qcom: shikra: enable ST33 TPM

 arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi |  1 -
 arch/arm64/boot/dts/qcom/shikra-evk.dtsi     | 10 ++++++++++
 arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi |  1 -
 3 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 65eb47183e176d8c1220cb945edac71dbedceac1
change-id: 20260825-shikra-dtpm-7490cacf0266

Best regards,
-- 
Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17
  2026-09-03  7:18 [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Khalid Faisal Ansari
@ 2026-09-03  7:18 ` Khalid Faisal Ansari
  2026-09-03  7:48   ` Abel Vesa
  2026-09-03  7:18 ` [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM Khalid Faisal Ansari
  2026-09-11  2:25 ` (subset) [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Khalid Faisal Ansari @ 2026-09-03  7:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Khalid Faisal Ansari,
	Konrad Dybcio

GPIOs 14-17 were previously reserved in the tlmm gpio-reserved-ranges,
preventing Linux from accessing SPI5. Removing them from the reserved
list across all three Shikra EVK variants (CQM, CQS, IQS) enables it
for dTPM usecase.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi | 1 -
 arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
index 8ac42ff625a0..fde7fc035bf5 100644
--- a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
@@ -197,7 +197,6 @@ pm4125_l22: l22 {
 
 &tlmm {
 	gpio-reserved-ranges = <6 4>, /* Fingerprint SPI */
-			       <14 4>, /* eSE SPI */
 			       <30 2>, /* NFC SPI */
 			       <138 1>, /* NFC Secure IO */
 			       <155 11>; /* eMMC Boot */
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
index 4ff97945274d..e119ace54e58 100644
--- a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
@@ -219,7 +219,6 @@ pm8150_l18: l18 {
 
 &tlmm {
 	 gpio-reserved-ranges = <6 4>, /* Fingerprint SPI */
-			       <14 4>, /* eSE SPI */
 			       <30 2>, /* NFC SPI */
 			       <138 1>, /* NFC Secure IO */
 			       <155 11>; /* eMMC Boot */

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM
  2026-09-03  7:18 [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Khalid Faisal Ansari
  2026-09-03  7:18 ` [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17 Khalid Faisal Ansari
@ 2026-09-03  7:18 ` Khalid Faisal Ansari
  2026-09-03  7:49   ` Abel Vesa
  2026-09-03  8:01   ` Konrad Dybcio
  2026-09-11  2:25 ` (subset) [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Bjorn Andersson
  2 siblings, 2 replies; 7+ messages in thread
From: Khalid Faisal Ansari @ 2026-09-03  7:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Khalid Faisal Ansari

Enable ST33HTPM TPM over SPI5 on the Shikra IoT EVK by adding the
required SPI and TPM nodes.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/shikra-evk.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/shikra-evk.dtsi b/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
index 6eb4184f7642..c073e45781a6 100644
--- a/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
@@ -9,6 +9,16 @@ &qupv3_0 {
 	status = "okay";
 };
 
+&spi5 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
+
 &uart0 {
 	status = "okay";
 };

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17
  2026-09-03  7:18 ` [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17 Khalid Faisal Ansari
@ 2026-09-03  7:48   ` Abel Vesa
  0 siblings, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2026-09-03  7:48 UTC (permalink / raw)
  To: Khalid Faisal Ansari
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio

On 26-09-03 12:48:53, Khalid Faisal Ansari wrote:
> GPIOs 14-17 were previously reserved in the tlmm gpio-reserved-ranges,
> preventing Linux from accessing SPI5. Removing them from the reserved
> list across all three Shikra EVK variants (CQM, CQS, IQS) enables it
> for dTPM usecase.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM
  2026-09-03  7:18 ` [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM Khalid Faisal Ansari
@ 2026-09-03  7:49   ` Abel Vesa
  2026-09-03  8:01   ` Konrad Dybcio
  1 sibling, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2026-09-03  7:49 UTC (permalink / raw)
  To: Khalid Faisal Ansari
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On 26-09-03 12:48:54, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI5 on the Shikra IoT EVK by adding the
> required SPI and TPM nodes.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM
  2026-09-03  7:18 ` [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM Khalid Faisal Ansari
  2026-09-03  7:49   ` Abel Vesa
@ 2026-09-03  8:01   ` Konrad Dybcio
  1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2026-09-03  8:01 UTC (permalink / raw)
  To: Khalid Faisal Ansari, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 9/3/26 9:18 AM, Khalid Faisal Ansari wrote:
> Enable ST33HTPM TPM over SPI5 on the Shikra IoT EVK by adding the
> required SPI and TPM nodes.
> 
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support
  2026-09-03  7:18 [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Khalid Faisal Ansari
  2026-09-03  7:18 ` [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17 Khalid Faisal Ansari
  2026-09-03  7:18 ` [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM Khalid Faisal Ansari
@ 2026-09-11  2:25 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2026-09-11  2:25 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Khalid Faisal Ansari
  Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio


On Thu, 03 Sep 2026 12:48:52 +0530, Khalid Faisal Ansari wrote:
> The Shikra EVK platforms support an ST33 TPM connected over SPI5.
> 
> This series first removes GPIOs 14-17 from the reserved ranges so
> that SPI5 can be used by Linux, and then enables the ST33 TPM in
> the common Shikra EVK device tree.
> 
> Changes in v5:
> - Add Reviewed-by tag from Konrad Dybcio for v4-patch 1.
> - Keep node references in alphabetical order.
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: shikra: enable ST33 TPM
      commit: 9f27d5c53a4d3b5a5ab80fe2efa7c72ed04e350e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-09-11  2:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-03  7:18 [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Khalid Faisal Ansari
2026-09-03  7:18 ` [PATCH v5 1/2] arm64: dts: qcom: shikra: unreserve GPIOs 14-17 Khalid Faisal Ansari
2026-09-03  7:48   ` Abel Vesa
2026-09-03  7:18 ` [PATCH v5 2/2] arm64: dts: qcom: shikra: enable ST33 TPM Khalid Faisal Ansari
2026-09-03  7:49   ` Abel Vesa
2026-09-03  8:01   ` Konrad Dybcio
2026-09-11  2:25 ` (subset) [PATCH v5 0/2] arm64: dts: qcom: shikra: enable ST33 TPM support Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.