Re: [PATCH v18 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub - sashiko-bot

From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
	Frank.Li@kernel.org, linux-i3c@lists.infradead.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v18 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub
Date: Thu, 03 Sep 2026 06:31:52 +0000	[thread overview]
Message-ID: <20260903063152.861631F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903062108.2712296-6-lakshay.piplani@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Driver-specific header placed in the global include/linux/mfd/ directory.
--

commit cbaa07506e1e33ad932d2b0d2d38edfb4437adc1
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>

regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub

This commit adds a regulator driver for the on-die regulators in the NXP 
P3H2x4x i3c hub. The driver registers the regulators using the MFD framework 
and exposes them via the regulator subsystem.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index d482a23c0bf78..bdf54313bc5f6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19772,6 +19772,7 @@ L:	linux-i3c@lists.infradead.org
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
>  F:	drivers/mfd/p3h2840.c
> +F:	drivers/regulator/p3h2840_i3c_hub_regulator.c
>  F:	include/linux/mfd/p3h2840.h

[ ... ]

> diff --git a/drivers/regulator/p3h2840_i3c_hub_regulator.c b/drivers/regulator/p3h2840_i3c_hub_regulator.c
> new file mode 100644
> index 0000000000000..244f2a4f70f38
> --- /dev/null
> +++ b/drivers/regulator/p3h2840_i3c_hub_regulator.c
> @@ -0,0 +1,289 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2025-2026 NXP
> + * NXP P3H2X4X regulator driver file contain functions for enable/disable regulator
> + * and voltage set/get.
> + */
> +#include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> +#include <linux/mfd/p3h2840.h>

[Severity: Low]
Does this driver include a shared header from the globally exported include
path rather than keeping it local?

The MFD subsystem guidelines state that driver-specific header files should
be kept local to drivers/mfd/ if they are only used by the parent and its
immediate children. Should p3h2840.h be moved out of the global namespace
if it is only used by this device family?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903062108.2712296-1-lakshay.piplani@nxp.com?part=5

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c