Re: [LTP] lapi/sched: add SAFE_SCHED_SETATTR()

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Sep 3, 2026, Andrea Cervesato wrote:
> lapi/sched: add SAFE_SCHED_SETATTR()

--- [PATCH 1/3] ---

> + * SAFE_SCHED_SETATTR() - Safe wrapper for sched_setattr().

linuxdoc requires macro names without the function suffix. Use
`SAFE_SCHED_SETATTR - Safe wrapper for sched_setattr().`

--- [PATCH 2/3] ---

> +struct prctl_mm_map {

This new public structure needs a kernel-doc comment with a
`struct prctl_mm_map` summary and entries for its members.

--- [PATCH 3/3] ---

> +	futex_lock_pi(&f_pi_chain);
> +
> +	TST_CHECKPOINT_WAKE(CP_CHAIN_HELD);

FUTEX_LOCK_PI can return ENOSYS at runtime, after which this checkpoint
incorrectly announces that the lock is held. Check all lock and unlock
calls, report ENOSYS as TCONF, and abort on other unexpected errors.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp