From: yangfeng <yangfeng.lucky@gmail.com>
To: tglx@kernel.org
Cc: radu@rendec.net, linux-kernel@vger.kernel.org,
yangfeng <yangfeng.lucky@gmail.com>
Subject: [PATCH] irq/debug: implement missing FIXME in print_irq_desc()
Date: Thu, 3 Sep 2026 22:19:15 +0900 [thread overview]
Message-ID: <20260903131916.61329-1-yangfeng.lucky@gmail.com> (raw)
The original code ___PD(f) left a FIXME, so fix it.
The maximum length of a macro is 15, so modify the printk().
Signed-off-by: yangfeng <yangfeng.lucky@gmail.com>
---
kernel/irq/debug.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h
index 8ccb326d2977..aa233cbeea38 100644
--- a/kernel/irq/debug.h
+++ b/kernel/irq/debug.h
@@ -5,8 +5,7 @@
#define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
#define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
-/* FIXME */
-#define ___PD(f) do { } while (0)
+#define ___PD(f) if (ACCESS_PRIVATE((&(desc->irq_data))->common, state_use_accessors) & f) printk("%14s set\n", #f)
static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
{
@@ -39,9 +38,9 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
___PS(IRQS_WAITING);
___PS(IRQS_PENDING);
- ___PD(IRQS_INPROGRESS);
- ___PD(IRQS_DISABLED);
- ___PD(IRQS_MASKED);
+ ___PD(IRQD_IRQ_INPROGRESS);
+ ___PD(IRQD_IRQ_DISABLED);
+ ___PD(IRQD_IRQ_MASKED);
}
#undef ___P
--
2.43.0
next reply other threads:[~2026-09-03 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:19 yangfeng [this message]
2026-09-04 6:20 ` [PATCH] irq/debug: implement missing FIXME in print_irq_desc() Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903131916.61329-1-yangfeng.lucky@gmail.com \
--to=yangfeng.lucky@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.