From: Thomas Gleixner <tglx@kernel.org>
To: yangfeng <yangfeng.lucky@gmail.com>
Cc: radu@rendec.net, linux-kernel@vger.kernel.org,
yangfeng <yangfeng.lucky@gmail.com>
Subject: Re: [PATCH] irq/debug: implement missing FIXME in print_irq_desc()
Date: Fri, 04 Sep 2026 08:20:27 +0200 [thread overview]
Message-ID: <87y0dh8rmc.ffs@fw13> (raw)
In-Reply-To: <20260903131916.61329-1-yangfeng.lucky@gmail.com>
On Thu, Sep 03 2026 at 22:19, yangfeng wrote:
The proper prefix is: genirq/debug:
> The original code ___PD(f) left a FIXME, so fix it.
That's really informative.
> The maximum length of a macro is 15, so modify the printk().
And this is just incomprehensible
> Signed-off-by: yangfeng <yangfeng.lucky@gmail.com>
You need to provide your full name not a nickname. See
Documentation/process.
> ---
> kernel/irq/debug.h | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h
> index 8ccb326d2977..aa233cbeea38 100644
> --- a/kernel/irq/debug.h
> +++ b/kernel/irq/debug.h
> @@ -5,8 +5,7 @@
>
> #define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
> #define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
> -/* FIXME */
> -#define ___PD(f) do { } while (0)
> +#define ___PD(f) if (ACCESS_PRIVATE((&(desc->irq_data))->common, state_use_accessors) & f) printk("%14s set\n", #f)
__irqd_to_state() exists for a reason and it's available in
internal.h. The define just needs to be before including debug.h.
prev parent reply other threads:[~2026-09-04 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:19 [PATCH] irq/debug: implement missing FIXME in print_irq_desc() yangfeng
2026-09-04 6:20 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0dh8rmc.ffs@fw13 \
--to=tglx@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radu@rendec.net \
--cc=yangfeng.lucky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.