All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] lib: Check minimal supported kernel version
@ 2026-09-04  8:07 Andrea Cervesato
  2026-09-04  9:20 ` [LTP] " linuxtestproject.agent
  2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
  0 siblings, 2 replies; 8+ messages in thread
From: Andrea Cervesato @ 2026-09-04  8:07 UTC (permalink / raw)
  To: Linux Test Project

From: Andrea Cervesato <andrea.cervesato@suse.com>

LTP does not support kernels older than 4.4, but this requirement was
only documented in static text without automated runtime validation.

Define the minimal supported kernel version in tst_kvercmp.h so that
the documentation fetches it dynamically and the core library aborts
unsupported kernels with TCONF during test setup.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
Add a variable to check minimum kernel version before running tests.
Until now, the only place we have to verify the minimum kernel is to
read the documentation.
---
 doc/conf.py                     | 15 +++++++++++++++
 doc/users/supported_systems.rst |  2 +-
 include/tst_kvercmp.h           |  7 ++++++-
 lib/tst_test.c                  | 17 +++++++++++++++++
 4 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/doc/conf.py b/doc/conf.py
index c28db7af1..69ea31b0c 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -21,6 +21,21 @@ ltp_repo = 'https://github.com/linux-test-project/ltp'
 ltp_repo_base_url = f"{ltp_repo}/tree/master"
 cve_url = "https://www.cve.org/CVERecord?id="
 
+def _get_min_kernel_version():
+    header_path = os.path.join(os.path.dirname(__file__), '../include/tst_kvercmp.h')
+    with open(header_path, 'r', encoding='utf-8') as f:
+        match = re.search(r'#define\s+TST_MIN_KVER\s+"([^"]+)"', f.read())
+        if match:
+            return match.group(1)
+    raise RuntimeError(f"Could not find TST_MIN_KVER in {header_path}")
+
+min_kernel_version = _get_min_kernel_version()
+
+rst_prolog = f"""
+.. |min_kernel_version| replace:: **{min_kernel_version}**
+.. |min_kernel_version_plain| replace:: {min_kernel_version}
+"""
+
 # -- General configuration ---------------------------------------------------
 # https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration
 
diff --git a/doc/users/supported_systems.rst b/doc/users/supported_systems.rst
index b5d792eeb..5765214b0 100644
--- a/doc/users/supported_systems.rst
+++ b/doc/users/supported_systems.rst
@@ -14,7 +14,7 @@ branch is build tested in
 Kernel version
 --------------
 
-Minimal supported kernel version is **4.4**.
+Minimal supported kernel version is |min_kernel_version|.
 
 Oldest build tested distributions
 ---------------------------------
diff --git a/include/tst_kvercmp.h b/include/tst_kvercmp.h
index 26e8f8e3c..52267fd2b 100644
--- a/include/tst_kvercmp.h
+++ b/include/tst_kvercmp.h
@@ -1,12 +1,17 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later
  * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
  * Copyright (c) 2009-2016 Cyril Hrubis chrubis@suse.cz
- * Copyright (c) Linux Test Project, 2020-2025
+ * Copyright (c) Linux Test Project, 2020-2026
  */
 
 #ifndef TST_KVERCMP_H__
 #define TST_KVERCMP_H__
 
+/**
+ * TST_MIN_KVER - Minimal kernel version supported by LTP.
+ */
+#define TST_MIN_KVER "4.4"
+
 /**
  * tst_kvcmp() - Compare given kernel version with kernel in string.
  *
diff --git a/lib/tst_test.c b/lib/tst_test.c
index 166e0f672..1bd62e24a 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -1087,6 +1087,21 @@ static bool check_kver(const char *min_kver, const int brk_nosupp)
 	return true;
 }
 
+static void check_supported_kver(void)
+{
+	int v1, v2, v3;
+
+	if (tst_parse_kver(TST_MIN_KVER, &v1, &v2, &v3)) {
+		tst_res(TWARN,
+			"Invalid minimal kernel version %s, expected %%d.%%d.%%d",
+			TST_MIN_KVER);
+		return;
+	}
+
+	if (tst_kvercmp(v1, v2, v3) < 0)
+		tst_brk(TCONF, "Kernel is older than minimal supported %s", TST_MIN_KVER);
+}
+
 /*
  * Checks if the struct results values are equal.
  *
@@ -1455,6 +1470,8 @@ static void do_setup(int argc, char *argv[])
 	if (context->tdebug)
 		tst_res(TINFO, "Enabling debug info (level %d)", context->tdebug);
 
+	check_supported_kver();
+
 	if (tst_test->needs_kconfigs && tst_kconfig_check(tst_test->needs_kconfigs))
 		tst_brk(TCONF, "Aborting due to unsuitable kernel config, see above!");
 

---
base-commit: d377d1cff1ec393459a136eec85088ffd5729430
change-id: 20260904-min_kernel-22066a2e046c

Best regards,
--  
Andrea Cervesato <andrea.cervesato@suse.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [LTP] lib: Check minimal supported kernel version
  2026-09-04  8:07 [LTP] [PATCH] lib: Check minimal supported kernel version Andrea Cervesato
@ 2026-09-04  9:20 ` linuxtestproject.agent
  2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
  1 sibling, 0 replies; 8+ messages in thread
From: linuxtestproject.agent @ 2026-09-04  9:20 UTC (permalink / raw)
  To: Andrea Cervesato; +Cc: ltp

Hi Andrea,

On September 4, 2026, Andrea Cervesato wrote:
> lib: Check minimal supported kernel version

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] [PATCH] lib: Check minimal supported kernel version
  2026-09-04  8:07 [LTP] [PATCH] lib: Check minimal supported kernel version Andrea Cervesato
  2026-09-04  9:20 ` [LTP] " linuxtestproject.agent
@ 2026-09-04  9:20 ` Cyril Hrubis
  2026-09-04  9:25   ` Andrea Cervesato via ltp
                     ` (2 more replies)
  1 sibling, 3 replies; 8+ messages in thread
From: Cyril Hrubis @ 2026-09-04  9:20 UTC (permalink / raw)
  To: Andrea Cervesato; +Cc: Linux Test Project

Hi!
> LTP does not support kernels older than 4.4, but this requirement was
> only documented in static text without automated runtime validation.
> 
> Define the minimal supported kernel version in tst_kvercmp.h so that
> the documentation fetches it dynamically and the core library aborts
> unsupported kernels with TCONF during test setup.

Great idea, but I wouldn't tst_brk() on older kernels, I would just
print a message that there may be failures becuase older kernels are not
supported or tested.

LTP has been historically used for many different purposes, e.g. for
testing BSD compatibility layout for running Linux binaries and I fear
that hard stop on older kernel versions would break these usecases.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] [PATCH] lib: Check minimal supported kernel version
  2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
@ 2026-09-04  9:25   ` Andrea Cervesato via ltp
  2026-09-04  9:51   ` Petr Vorel
  2026-09-07  8:32   ` Kubaj, Piotr
  2 siblings, 0 replies; 8+ messages in thread
From: Andrea Cervesato via ltp @ 2026-09-04  9:25 UTC (permalink / raw)
  To: Cyril Hrubis; +Cc: Linux Test Project

Hi Cyril,

> Hi!
> > LTP does not support kernels older than 4.4, but this requirement was
> > only documented in static text without automated runtime validation.
> > 
> > Define the minimal supported kernel version in tst_kvercmp.h so that
> > the documentation fetches it dynamically and the core library aborts
> > unsupported kernels with TCONF during test setup.
> 
> Great idea, but I wouldn't tst_brk() on older kernels, I would just
> print a message that there may be failures becuase older kernels are not
> supported or tested.
> 
> LTP has been historically used for many different purposes, e.g. for
> testing BSD compatibility layout for running Linux binaries and I fear
> that hard stop on older kernel versions would break these usecases.

makes sense, I will send v2.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] [PATCH] lib: Check minimal supported kernel version
  2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
  2026-09-04  9:25   ` Andrea Cervesato via ltp
@ 2026-09-04  9:51   ` Petr Vorel
  2026-09-07  8:32   ` Kubaj, Piotr
  2 siblings, 0 replies; 8+ messages in thread
From: Petr Vorel @ 2026-09-04  9:51 UTC (permalink / raw)
  To: Cyril Hrubis; +Cc: Linux Test Project

> Hi!
> > LTP does not support kernels older than 4.4, but this requirement was
> > only documented in static text without automated runtime validation.

> > Define the minimal supported kernel version in tst_kvercmp.h so that
> > the documentation fetches it dynamically and the core library aborts
> > unsupported kernels with TCONF during test setup.

> Great idea, but I wouldn't tst_brk() on older kernels, I would just
> print a message that there may be failures becuase older kernels are not
> supported or tested.

Yes, exactly, tst_brk() is way too aggressive. tst_res(TINFO) is good enough
to give the information without deliberately break all the tests.

> LTP has been historically used for many different purposes, e.g. for
> testing BSD compatibility layout for running Linux binaries and I fear
> that hard stop on older kernel versions would break these usecases.

+1.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] lib: Check minimal supported kernel version
  2026-09-04  9:34 [LTP] [PATCH v2] " Andrea Cervesato
@ 2026-09-04 10:41 ` linuxtestproject.agent
  2026-09-04 10:45   ` Andrea Cervesato via ltp
  0 siblings, 1 reply; 8+ messages in thread
From: linuxtestproject.agent @ 2026-09-04 10:41 UTC (permalink / raw)
  To: Andrea Cervesato; +Cc: ltp

Hi Andrea,

On Fri, 4 Sep 2026, Andrea Cervesato wrote:
> lib: Check minimal supported kernel version

> +	if (tst_kvercmp(v1, v2, v3) < 0)
> +		tst_brk(TWARN, "Kernel is older than minimal supported %s", TST_MIN_KVER);

This exits with TWARN, contrary to the commit message's stated TCONF
behavior. Use tst_brk(TCONF, ...) so unsupported kernels are reported as
skipped configurations.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] lib: Check minimal supported kernel version
  2026-09-04 10:41 ` [LTP] " linuxtestproject.agent
@ 2026-09-04 10:45   ` Andrea Cervesato via ltp
  0 siblings, 0 replies; 8+ messages in thread
From: Andrea Cervesato via ltp @ 2026-09-04 10:45 UTC (permalink / raw)
  To: linuxtestproject.agent; +Cc: ltp

> This exits with TWARN, contrary to the commit message's stated TCONF
> behavior. Use tst_brk(TCONF, ...) so unsupported kernels are reported as
> skipped configurations.

@Petr @Cyril @Li This can be fixed before merge if you agree with it.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [LTP] [PATCH] lib: Check minimal supported kernel version
  2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
  2026-09-04  9:25   ` Andrea Cervesato via ltp
  2026-09-04  9:51   ` Petr Vorel
@ 2026-09-07  8:32   ` Kubaj, Piotr
  2 siblings, 0 replies; 8+ messages in thread
From: Kubaj, Piotr @ 2026-09-07  8:32 UTC (permalink / raw)
  To: andrea.cervesato@suse.de, chrubis@suse.cz; +Cc: ltp@lists.linux.it

W dniu pią, 04.09.2026 o godzinie 11∶20 +0200, użytkownik Cyril Hrubis
napisał:
> Hi!
> > LTP does not support kernels older than 4.4, but this requirement
> > was
> > only documented in static text without automated runtime
> > validation.
> > 
> > Define the minimal supported kernel version in tst_kvercmp.h so
> > that
> > the documentation fetches it dynamically and the core library
> > aborts
> > unsupported kernels with TCONF during test setup.
> 
> Great idea, but I wouldn't tst_brk() on older kernels, I would just
> print a message that there may be failures becuase older kernels are
> not
> supported or tested.
> 
> LTP has been historically used for many different purposes, e.g. for
> testing BSD compatibility layout for running Linux binaries and I
> fear
> that hard stop on older kernel versions would break these usecases.
> 
> -- 
> Cyril Hrubis
> chrubis@suse.cz
Hi,

speaking with my pkubaj@FreeBSD.org hat on, see
https://cgit.freebsd.org/src/tree/sys/compat/linux/linux_mib.h

The current claimed compatibility level is Linux 5.15.0. Even if you
look at
https://cgit.freebsd.org/src/tree/sys/compat/linux/linux_mib.h?h=releng%2F14.4
(which is the oldest still-supported version), it's also 5.15.0.

I think NetBSD also has a Linux compatibility layer, but I'm not sure
how up-to-date it is.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-09-07  8:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-04  8:07 [LTP] [PATCH] lib: Check minimal supported kernel version Andrea Cervesato
2026-09-04  9:20 ` [LTP] " linuxtestproject.agent
2026-09-04  9:20 ` [LTP] [PATCH] " Cyril Hrubis
2026-09-04  9:25   ` Andrea Cervesato via ltp
2026-09-04  9:51   ` Petr Vorel
2026-09-07  8:32   ` Kubaj, Piotr
  -- strict thread matches above, loose matches on Subject: below --
2026-09-04  9:34 [LTP] [PATCH v2] " Andrea Cervesato
2026-09-04 10:41 ` [LTP] " linuxtestproject.agent
2026-09-04 10:45   ` Andrea Cervesato via ltp

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.