From: sashiko-bot@kernel.org
To: "Hemanth Selam" <hemanth.selam@gmail.com>
Cc: linux-ide@vger.kernel.org, cassel@kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH 2/2] ata: fix repeated words in comments
Date: Fri, 04 Sep 2026 12:34:42 +0000 [thread overview]
Message-ID: <20260904123442.979F31F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904123110.35532-3-hemanth.selam@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch blindly removes a valid occurrence of the word 'in', creating a grammatical error in the comment.
--
commit 82b3223c0ee5c7c14e26327dc44e83c5226cc9b8
Author: Hemanth Selam <hemanth.selam@gmail.com>
ata: fix repeated words in comments
This commit drops repeated words in comments reported by checkpatch.pl.
It only touches comments and makes no code changes.
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index c154103d892c3..bdf25c535c07c 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
> *
> * Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
> * is non-zero and EH wasn't pending before. Fast drain ensures
> - * that EH kicks in in timely manner.
> + * that EH kicks in timely manner.
[Severity: Low]
Does this accidentally remove a valid occurrence of the word "in"?
The original text uses "in" twice for two different grammatical purposes: the
first is part of the phrasal verb "kick in", and the second is the preposition
for "in [a] timely manner".
Removing the second one leaves the sentence missing a preposition.
Would it be better to change this to "EH kicks in in a timely manner" or
"EH kicks in promptly" instead of just dropping the word?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904123207.36203-1-hemanth.selam@gmail.com?part=2
next prev parent reply other threads:[~2026-09-04 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260904123110.35532-1-hemanth.selam@gmail.com>
2026-09-04 12:31 ` [PATCH 2/2] ata: fix repeated words in comments Hemanth Selam
2026-09-04 12:34 ` sashiko-bot [this message]
2026-09-05 0:41 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904123442.979F31F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hemanth.selam@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.