From: Damien Le Moal <dlemoal@kernel.org>
To: Hemanth Selam <hemanth.selam@gmail.com>,
Niklas Cassel <cassel@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] ata: fix repeated words in comments
Date: Sat, 5 Sep 2026 09:41:39 +0900 [thread overview]
Message-ID: <6e066029-94df-480e-95ea-3b27ae8387ad@kernel.org> (raw)
In-Reply-To: <20260904123110.35532-3-hemanth.selam@gmail.com>
On 9/4/26 21:31, Hemanth Selam wrote:
> Drop words accidentally written twice, reported by checkpatch.pl as a
> possible repeated word. Only touches comments, no code changes.
>
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
> drivers/ata/libata-eh.c | 2 +-
> drivers/ata/sata_dwc_460ex.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index c93c24b22d9c..630e6d44190b 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
> *
> * Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
> * is non-zero and EH wasn't pending before. Fast drain ensures
> - * that EH kicks in in timely manner.
> + * that EH kicks in timely manner.
Sashiko is correct here. This is the wrong fix. This should read:
"that EH kicks in in a timely manner."
In any case, this is all very minor and I prefer that we do not apply this patch
to avoid churn and backport issues and rather get these typos fixed when the
code around them changes.
> *
> * LOCKING:
> * spin_lock_irqsave(host lock)
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 8e3fc713891a..b0c069a02cc2 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -1071,7 +1071,7 @@ static const struct scsi_host_template sata_dwc_sht = {
> /*
> * test-only: Currently this driver doesn't handle NCQ
> * correctly. We enable NCQ but set the queue depth to a
> - * max of 1. This will get fixed in in a future release.
> + * max of 1. This will get fixed in a future release.
> */
> .sg_tablesize = LIBATA_MAX_PRD,
> /* .can_queue = ATA_MAX_QUEUE, */
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-09-05 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260904123110.35532-1-hemanth.selam@gmail.com>
2026-09-04 12:31 ` [PATCH 2/2] ata: fix repeated words in comments Hemanth Selam
2026-09-04 12:34 ` sashiko-bot
2026-09-05 0:41 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e066029-94df-480e-95ea-3b27ae8387ad@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hemanth.selam@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.