[PATCH 2/2] ata: fix repeated words in comments

[PATCH 2/2] ata: fix repeated words in comments

[Hemanth Selam]

Drop words accidentally written twice, reported by checkpatch.pl as a
possible repeated word.  Only touches comments, no code changes.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/ata/libata-eh.c      | 2 +-
 drivers/ata/sata_dwc_460ex.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index c93c24b22d9c..630e6d44190b 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
  *
  *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
  *	is non-zero and EH wasn't pending before.  Fast drain ensures
- *	that EH kicks in in timely manner.
+ *	that EH kicks in timely manner.
  *
  *	LOCKING:
  *	spin_lock_irqsave(host lock)
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 8e3fc713891a..b0c069a02cc2 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1071,7 +1071,7 @@ static const struct scsi_host_template sata_dwc_sht = {
 	/*
 	 * test-only: Currently this driver doesn't handle NCQ
 	 * correctly. We enable NCQ but set the queue depth to a
-	 * max of 1. This will get fixed in in a future release.
+	 * max of 1. This will get fixed in a future release.
 	 */
 	.sg_tablesize		= LIBATA_MAX_PRD,
 	/* .can_queue		= ATA_MAX_QUEUE, */
-- 
2.48.1

Re: [PATCH 2/2] ata: fix repeated words in comments

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch blindly removes a valid occurrence of the word 'in', creating a grammatical error in the comment.
--

commit 82b3223c0ee5c7c14e26327dc44e83c5226cc9b8
Author: Hemanth Selam <hemanth.selam@gmail.com>

ata: fix repeated words in comments

This commit drops repeated words in comments reported by checkpatch.pl.
It only touches comments and makes no code changes.

> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index c154103d892c3..bdf25c535c07c 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
>   *
>   *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
>   *	is non-zero and EH wasn't pending before.  Fast drain ensures
> - *	that EH kicks in in timely manner.
> + *	that EH kicks in timely manner.

[Severity: Low]
Does this accidentally remove a valid occurrence of the word "in"?

The original text uses "in" twice for two different grammatical purposes: the
first is part of the phrasal verb "kick in", and the second is the preposition
for "in [a] timely manner".

Removing the second one leaves the sentence missing a preposition.

Would it be better to change this to "EH kicks in in a timely manner" or 
"EH kicks in promptly" instead of just dropping the word?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904123207.36203-1-hemanth.selam@gmail.com?part=2

Re: [PATCH 2/2] ata: fix repeated words in comments

[Damien Le Moal]

On 9/4/26 21:31, Hemanth Selam wrote:
> Drop words accidentally written twice, reported by checkpatch.pl as a
> possible repeated word.  Only touches comments, no code changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/ata/libata-eh.c      | 2 +-
>  drivers/ata/sata_dwc_460ex.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index c93c24b22d9c..630e6d44190b 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
>   *
>   *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
>   *	is non-zero and EH wasn't pending before.  Fast drain ensures
> - *	that EH kicks in in timely manner.
> + *	that EH kicks in timely manner.

Sashiko is correct here. This is the wrong fix. This should read:

"that EH kicks in in a timely manner."

In any case, this is all very minor and I prefer that we do not apply this patch
to avoid churn and backport issues and rather get these typos fixed when the
code around them changes.

>   *
>   *	LOCKING:
>   *	spin_lock_irqsave(host lock)
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 8e3fc713891a..b0c069a02cc2 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -1071,7 +1071,7 @@ static const struct scsi_host_template sata_dwc_sht = {
>  	/*
>  	 * test-only: Currently this driver doesn't handle NCQ
>  	 * correctly. We enable NCQ but set the queue depth to a
> -	 * max of 1. This will get fixed in in a future release.
> +	 * max of 1. This will get fixed in a future release.
>  	 */
>  	.sg_tablesize		= LIBATA_MAX_PRD,
>  	/* .can_queue		= ATA_MAX_QUEUE, */


-- 
Damien Le Moal
Western Digital Research