From: sashiko-bot@kernel.org
To: "Muzaffer Kadir" <muzafferkadir@mainlining.org>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl
Date: Fri, 04 Sep 2026 13:05:40 +0000 [thread overview]
Message-ID: <20260904130540.CFFF31F0155B@smtp.kernel.org> (raw)
In-Reply-To: <20260904-msm8952-pinctrl-v4-1-671475ed1397@mainlining.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `maxItems` limit for `gpio-reserved-ranges` is mathematically off-by-one, artificially preventing the maximum possible fragmentation of reserved ranges.
--
commit c09a958e0a0865ed0afbe7d8e7ad728062dcbdf7
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>
dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl
Add device tree bindings for the TLMM pin controller found on the
Qualcomm MSM8952 platform.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml
> @@ -0,0 +1,146 @@
[ ... ]
> + interrupts:
> + maxItems: 1
> +
> + gpio-reserved-ranges:
> + minItems: 1
> + maxItems: 66
[Severity: Low]
Does this maxItems limit artificially prevent the maximum possible fragmentation
of reserved ranges?
The SoC defines 134 GPIO pins (0 through 133). In the worst-case fragmentation
scenario where every alternating pin is reserved (e.g., 0, 2, 4, ..., 132),
wouldn't this result in exactly 67 disjoint reserved ranges rather than 66?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-msm8952-pinctrl-v4-0-671475ed1397@mainlining.org?part=1
next prev parent reply other threads:[~2026-09-04 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 12:55 [PATCH v4 0/2] Add pinctrl support for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 12:55 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 13:05 ` sashiko-bot [this message]
2026-09-07 9:56 ` Krzysztof Kozlowski
2026-09-04 12:55 ` [PATCH v4 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 13:13 ` sashiko-bot
2026-09-07 12:04 ` Konrad Dybcio
2026-09-07 13:32 ` Muzaffer Kadir
2026-09-07 13:39 ` Konrad Dybcio
2026-09-07 14:19 ` Muzaffer Kadir
2026-09-07 14:28 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904130540.CFFF31F0155B@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=muzafferkadir@mainlining.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.