From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: muzafferkadir@mainlining.org,
Bartosz Golaszewski <brgl@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver
Date: Mon, 7 Sep 2026 14:04:59 +0200 [thread overview]
Message-ID: <ef41a092-cd83-4e65-a16a-7a8b838bcb63@oss.qualcomm.com> (raw)
In-Reply-To: <20260904-msm8952-pinctrl-v4-2-671475ed1397@mainlining.org>
On 04-Sep-26 14:55, Muzaffer Kadir via B4 Relay wrote:
> From: Muzaffer Kadir <muzafferkadir@mainlining.org>
>
> MSM8952 has same pin count and similar pinctrl
> functions mostly with msm8917, but some functions use different pins.
>
> Signed-off-by: Muzaffer Kadir <muzafferkadir@mainlining.org>
> ---
I told the robot to take a look again (and again and again
a couple more times until it stopped complaining)..
The following feedback is meaningful:
Hi Muzaffer,
`qdss_tracedata_b_groups` advertises GPIOs that cannot actually select
the function. Please populate the corresponding PINGROUP slots:
GPIO8: mux 11
GPIO9: mux 12
GPIO12: mux 12
GPIO13: mux 12
Minor nit: use MODULE_LICENSE("GPL") to match the nearby Qualcomm
pinctrl drivers. // and checkpatch will ask you to do the same
Konrad
next prev parent reply other threads:[~2026-09-07 12:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 12:55 [PATCH v4 0/2] Add pinctrl support for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 12:55 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 13:05 ` sashiko-bot
2026-09-07 9:56 ` Krzysztof Kozlowski
2026-09-04 12:55 ` [PATCH v4 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver Muzaffer Kadir via B4 Relay
2026-09-04 12:55 ` Muzaffer Kadir
2026-09-04 13:13 ` sashiko-bot
2026-09-07 12:04 ` Konrad Dybcio [this message]
2026-09-07 13:32 ` Muzaffer Kadir
2026-09-07 13:39 ` Konrad Dybcio
2026-09-07 14:19 ` Muzaffer Kadir
2026-09-07 14:28 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef41a092-cd83-4e65-a16a-7a8b838bcb63@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muzafferkadir@mainlining.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.