From: sashiko-bot@kernel.org
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: robh@kernel.org, mfd@lists.linux.dev, neil.armstrong@linaro.org,
lee@kernel.org, vkoul@kernel.org, linux-clk@vger.kernel.org,
olteanv@gmail.com, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 10/19] drm/bridge: inno-hdmi: Add .mode_valid platform operation
Date: Fri, 04 Sep 2026 13:40:03 +0000 [thread overview]
Message-ID: <20260904134003.DB1F71F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904-jh7110-clean-send-v3-10-484f9ae72715@samsung.com>
> inno_hdmi_bridge_mode_valid() validates the pixel clock against
> hdmi->refclk, but that clock is optional and is only present on
> platforms that describe a "ref" clock. Platforms where the pixel clock
> is produced by a separate device - such as the StarFive JH7110, whose
> PHY is both the clock and the PHY provider - have no "ref" clock, so
> the check is skipped entirely and every mode is reported as valid.
>
> A mode the platform cannot generate is then advertised to userspace.
> The subsequent modeset appears to succeed, since the atomic enable path
> cannot fail, and the display silently stays blank.
>
> Add a .mode_valid platform operation so platforms can reject modes they
> are unable to drive. Platforms that do not implement it are unaffected.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com?part=10
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: robh@kernel.org, mfd@lists.linux.dev, neil.armstrong@linaro.org,
lee@kernel.org, vkoul@kernel.org, linux-clk@vger.kernel.org,
olteanv@gmail.com, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 10/19] drm/bridge: inno-hdmi: Add .mode_valid platform operation
Date: Fri, 04 Sep 2026 13:40:03 +0000 [thread overview]
Message-ID: <20260904134003.DB1F71F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904-jh7110-clean-send-v3-10-484f9ae72715@samsung.com>
> inno_hdmi_bridge_mode_valid() validates the pixel clock against
> hdmi->refclk, but that clock is optional and is only present on
> platforms that describe a "ref" clock. Platforms where the pixel clock
> is produced by a separate device - such as the StarFive JH7110, whose
> PHY is both the clock and the PHY provider - have no "ref" clock, so
> the check is skipped entirely and every mode is reported as valid.
>
> A mode the platform cannot generate is then advertised to userspace.
> The subsequent modeset appears to succeed, since the atomic enable path
> cannot fail, and the display silently stays blank.
>
> Add a .mode_valid platform operation so platforms can reject modes they
> are unable to drive. Platforms that do not implement it are unaffected.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com?part=10
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-09-04 13:40 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260904132708eucas1p1adfa26ef0fe5109eca63a3aeadf74915@eucas1p1.samsung.com>
2026-09-04 13:27 ` [PATCH v3 00/19] drm: starfive: jh7110: Enable display subsystem Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` [PATCH v3 01/19] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:30 ` sashiko-bot
2026-09-04 13:30 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 02/19] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:35 ` sashiko-bot
2026-09-04 13:35 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 03/19] dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:37 ` sashiko-bot
2026-09-04 13:37 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 04/19] dt-bindings: soc: starfive: Add starfive,jh7110-vout-syscon Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:30 ` sashiko-bot
2026-09-04 13:30 ` sashiko-bot
2026-09-10 8:18 ` Krzysztof Kozlowski
2026-09-10 8:18 ` Krzysztof Kozlowski
2026-09-10 8:18 ` Krzysztof Kozlowski
2026-09-10 8:18 ` Krzysztof Kozlowski
2026-09-04 13:27 ` [PATCH v3 05/19] dt-bindings: soc: starfive: Add starfive,jh7110-vout-subsystem Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:36 ` sashiko-bot
2026-09-04 13:36 ` sashiko-bot
2026-09-10 8:21 ` Krzysztof Kozlowski
2026-09-10 8:21 ` Krzysztof Kozlowski
2026-09-10 8:21 ` Krzysztof Kozlowski
2026-09-10 8:21 ` Krzysztof Kozlowski
2026-09-04 13:27 ` [PATCH v3 06/19] dt-bindings: display: verisilicon: Add starfive,jh7110-dc8200 Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:31 ` sashiko-bot
2026-09-04 13:31 ` sashiko-bot
2026-09-10 8:34 ` Krzysztof Kozlowski
2026-09-10 8:34 ` Krzysztof Kozlowski
2026-09-10 8:34 ` Krzysztof Kozlowski
2026-09-10 8:34 ` Krzysztof Kozlowski
2026-09-04 13:27 ` [PATCH v3 07/19] drm/bridge: inno-hdmi: Split probe out of bind Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:42 ` sashiko-bot
2026-09-04 13:42 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 08/19] drm/bridge: inno-hdmi: Allow the register map to come from a parent Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:43 ` sashiko-bot
2026-09-04 13:43 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 09/19] drm/bridge: inno-hdmi: Add .disable platform operation Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:49 ` sashiko-bot
2026-09-04 13:49 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 10/19] drm/bridge: inno-hdmi: Add .mode_valid " Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:40 ` sashiko-bot [this message]
2026-09-04 13:40 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 11/19] soc: starfive: Add jh7110-hdmi-subsystem driver Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:52 ` sashiko-bot
2026-09-04 13:52 ` sashiko-bot
2026-09-07 8:23 ` Uwe Kleine-König
2026-09-07 8:23 ` Uwe Kleine-König
2026-09-07 8:23 ` Uwe Kleine-König
2026-09-07 8:23 ` Uwe Kleine-König
2026-09-04 13:27 ` [PATCH v3 12/19] soc: starfive: Add jh7110-vout-subsystem driver Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:47 ` sashiko-bot
2026-09-04 13:47 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 13/19] clk: starfive: jh7110-vout: Allow pixel clock rate propagation Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:44 ` sashiko-bot
2026-09-04 13:44 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 14/19] drm/bridge: starfive: Add JH7110 HDMI controller driver Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:39 ` Icenowy Zheng
2026-09-04 13:39 ` Icenowy Zheng
2026-09-04 13:39 ` Icenowy Zheng
2026-09-04 13:39 ` Icenowy Zheng
2026-09-04 13:57 ` sashiko-bot
2026-09-04 13:57 ` sashiko-bot
2026-09-07 3:51 ` Chaoyi Chen
2026-09-07 3:51 ` Chaoyi Chen
2026-09-07 3:51 ` Chaoyi Chen
2026-09-07 3:51 ` Chaoyi Chen
2026-09-04 13:27 ` [PATCH v3 15/19] phy: Add common Innosilicon HDMI PHY helpers Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:55 ` sashiko-bot
2026-09-04 13:55 ` sashiko-bot
2026-09-07 3:16 ` Chaoyi Chen
2026-09-07 3:16 ` Chaoyi Chen
2026-09-07 3:16 ` Chaoyi Chen
2026-09-07 3:16 ` Chaoyi Chen
2026-09-04 13:27 ` [PATCH v3 16/19] phy: rockchip: inno-hdmi: Use the common Innosilicon " Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:59 ` sashiko-bot
2026-09-04 13:59 ` sashiko-bot
2026-09-07 3:20 ` Chaoyi Chen
2026-09-07 3:20 ` Chaoyi Chen
2026-09-07 3:20 ` Chaoyi Chen
2026-09-07 3:20 ` Chaoyi Chen
2026-09-04 13:27 ` [PATCH v3 17/19] phy: starfive: Add jh7110-inno-hdmi-phy driver Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:57 ` sashiko-bot
2026-09-04 13:57 ` sashiko-bot
2026-09-04 13:27 ` [PATCH v3 18/19] riscv: dts: starfive: jh7110: Update DT for display subsystem Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 14:03 ` sashiko-bot
2026-09-04 14:03 ` sashiko-bot
2026-09-10 8:37 ` Krzysztof Kozlowski
2026-09-10 8:37 ` Krzysztof Kozlowski
2026-09-10 8:37 ` Krzysztof Kozlowski
2026-09-10 8:37 ` Krzysztof Kozlowski
2026-09-04 13:27 ` [PATCH v3 19/19] MAINTAINERS: Add StarFive JH7110 display subsystem entry Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 13:27 ` Michal Wilczynski
2026-09-04 15:13 ` [PATCH v3 00/19] drm: starfive: jh7110: Enable display subsystem Joshua Peisach
2026-09-04 15:13 ` Joshua Peisach
2026-09-04 15:13 ` Joshua Peisach
2026-09-04 15:13 ` Joshua Peisach
2026-09-05 5:21 ` Maud Spierings
2026-09-05 5:21 ` Maud Spierings
2026-09-05 5:21 ` Maud Spierings
2026-09-05 5:21 ` Maud Spierings
2026-09-06 3:55 ` Dominique Belhachemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904134003.DB1F71F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=mfd@lists.linux.dev \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.