All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ulf Hansson <ulfh@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Long Wan <long.wan@linux.spacemit.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: mmc: spacemit,sdhci: Add tx delay property
Date: Fri, 4 Sep 2026 20:32:19 +0000	[thread overview]
Message-ID: <20260904203219-GKC1974@kernel.org> (raw)
In-Reply-To: <20260903-tactful-scorpion-from-nibiru-a4ebe2@quoll>

Hi Krzysztof,

On 15:00 Thu 03 Sep     , Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 07:03:13AM +0000, Yixun Lan wrote:
> > From: Long Wan <long.wan@linux.spacemit.com>
> > 
> > Introduce a vendor specific property to configure the step count of TX
> > delay line which should be applied before RX tuning, compensating for
> > board level trace differences. The TX delay line result comes from test
> > out of real board which vary from different hardware layout.
> > 
> > Signed-off-by: Long Wan <long.wan@linux.spacemit.com>
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > index f35bf7ce08dd..3399a2d076dc 100644
> > --- a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > @@ -63,6 +63,16 @@ properties:
> >    pinctrl-1:
> >      description: Optional pinctrl state for 1.8V UHS operation with "uhs" name
> >  
> > +  spacemit,tx-delay:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 0
> > +    maximum: 255
> 
> default: 0, I guess?
> 
It's actually 127, I will fix it in next version

Also in my second thought, I will change the data type to uint8
then drop this additional minimum/maximum property, which will
 also simplify the code with device_property_read_u8() a bit

-- 
Yixun Lan (dlan)

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ulf Hansson <ulfh@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Long Wan <long.wan@linux.spacemit.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: mmc: spacemit,sdhci: Add tx delay property
Date: Fri, 4 Sep 2026 20:32:19 +0000	[thread overview]
Message-ID: <20260904203219-GKC1974@kernel.org> (raw)
In-Reply-To: <20260903-tactful-scorpion-from-nibiru-a4ebe2@quoll>

Hi Krzysztof,

On 15:00 Thu 03 Sep     , Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 07:03:13AM +0000, Yixun Lan wrote:
> > From: Long Wan <long.wan@linux.spacemit.com>
> > 
> > Introduce a vendor specific property to configure the step count of TX
> > delay line which should be applied before RX tuning, compensating for
> > board level trace differences. The TX delay line result comes from test
> > out of real board which vary from different hardware layout.
> > 
> > Signed-off-by: Long Wan <long.wan@linux.spacemit.com>
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > index f35bf7ce08dd..3399a2d076dc 100644
> > --- a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > @@ -63,6 +63,16 @@ properties:
> >    pinctrl-1:
> >      description: Optional pinctrl state for 1.8V UHS operation with "uhs" name
> >  
> > +  spacemit,tx-delay:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 0
> > +    maximum: 255
> 
> default: 0, I guess?
> 
It's actually 127, I will fix it in next version

Also in my second thought, I will change the data type to uint8
then drop this additional minimum/maximum property, which will
 also simplify the code with device_property_read_u8() a bit

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-09-04 20:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  7:03 [PATCH 0/4] mmc: spacemit: Introduce two DT properties Yixun Lan
2026-09-02  7:03 ` Yixun Lan
2026-09-02  7:03 ` [PATCH 1/4] dt-bindings: mmc: spacemit-sdhci: Add clock-frequency property Yixun Lan
2026-09-02  7:03   ` Yixun Lan
2026-09-02  7:11   ` sashiko-bot
2026-09-02  9:08     ` Yixun Lan
2026-09-02  7:03 ` [PATCH 2/4] dt-bindings: mmc: spacemit,sdhci: Add tx delay property Yixun Lan
2026-09-02  7:03   ` Yixun Lan
2026-09-02 18:03   ` Conor Dooley
2026-09-02 18:03     ` Conor Dooley
2026-09-03 13:00   ` Krzysztof Kozlowski
2026-09-03 13:00     ` Krzysztof Kozlowski
2026-09-04 20:32     ` Yixun Lan [this message]
2026-09-04 20:32       ` Yixun Lan
2026-09-02  7:03 ` [PATCH 3/4] mmc: sdhci-of-k1: Set clock-frequency of io clock Yixun Lan
2026-09-02  7:03   ` Yixun Lan
2026-09-02  7:14   ` sashiko-bot
2026-09-03  3:29   ` Troy Mitchell
2026-09-03  3:29     ` Troy Mitchell
2026-09-03 10:29     ` Yixun Lan
2026-09-03 10:29       ` Yixun Lan
2026-09-02  7:03 ` [PATCH 4/4] mmc: sdhci-of-k1: Add TX tuning parameter Yixun Lan
2026-09-02  7:03   ` Yixun Lan
2026-09-03  3:27   ` Troy Mitchell
2026-09-03  3:27     ` Troy Mitchell
2026-09-03 10:37     ` Yixun Lan
2026-09-03 10:37       ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904203219-GKC1974@kernel.org \
    --to=dlan@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=long.wan@linux.spacemit.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.