Re: [PATCH v4 01/40] scsi: define all additional sense codes and their qualifiers

[sashiko-bot@kernel.org]

> Introduce the file include/scsi/scsi_sense.h to define all existing
> additional sense codes and their combinations with additional sense code
> qualifiers, according to the most current T10 list available at
> https://www.t10.org/lists/asc-num.txt.
> 
> Additional sense codes (ASCs) are individually defined as an 8-bit value
> with the ASC_ name prefix. The combination of all ASCs with T10 defined
> possible non-zero code qualifiers are defined as 16-bits values. The
> 16-bits value for ASCs with a zero ASCQ are defined together with the ASC
> 8-code using the ASC() macro.
> 
> The sense key macro definitions in include/scsi/scsi_proto.h are also
> moved into this new file and scsi_sense.h is included in scsi_proto.h. The
> helper function scsi_sense_code() is defined to facilitate generating a
> 16-bits sense code from 8-bits ASC and ASCQ. The accessors
> scsi_sense_code_asc() and scsi_sense_code_ascq() are defined for the
> reverse operation, that is, to respectively extract an ASC and an ASCQ
> from a 16-bits sense code.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905032224.509860-1-dlemoal@kernel.org?part=1