Re: [PATCH v4 22/40] scsi: myrX: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the missing scsi_done() call for emulated REQUEST_SENSE commands causes a command timeout.
--

commit f3ff7cfa5745e4930586f17ede3cb83961872a54
Author: Damien Le Moal <dlemoal@kernel.org>

scsi: myrX: use 16-bits defined sense codes

Refactor the Mylex RAID controller driver to use scsi_set_sense() and the
16-bits sense_code field of struct scsi_sense_hdr and replace all
hard-coded additional sense codes and additional sense code qualifiers
with the enum values defined in include/scsi/scsi_sense.h. This helps with
code clarity as the sense codes being processed are easier to test and
self-documented.

> diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
> index 3678b66310ed0..e7d796add9864 100644
> --- a/drivers/scsi/myrb.c
> +++ b/drivers/scsi/myrb.c

[ ... ]

> @@ -1493,8 +1495,8 @@ static enum scsi_qc_status myrb_ldev_queuecommand(struct Scsi_Host *shost,
>  		return 0;

[Severity: High]
This isn't a bug introduced by this patch, but is the REQUEST_SENSE
case in myrb_ldev_queuecommand() missing a call to scsi_done() before
returning?

Looking at the preceding lines in myrb_ldev_queuecommand():

	case REQUEST_SENSE:
		myrb_request_sense(cb, scmd);
		scmd->result = (DID_OK << 16);
		return 0;

It appears the SCSI command never completes. Without calling scsi_done(),
wouldn't the command time out and trigger SCSI error handler escalation?

Could this allow a user issuing a REQUEST_SENSE command via the SG_IO
ioctl to cause a local denial of service via adapter reset?

>  	case SEND_DIAGNOSTIC:
>  		if (scmd->cmnd[1] != 0x04) {
> -			/* Illegal request, invalid field in CDB */
> -			scsi_build_sense(scmd, 0, ILLEGAL_REQUEST, 0x24, 0);
> +			scsi_set_sense(scmd, 0, ILLEGAL_REQUEST,
> +				       INVALID_FIELD_IN_CDB);
>  		} else {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905032224.509860-1-dlemoal@kernel.org?part=22