From: Yixun Lan <dlan@kernel.org>
To: Eric Chung <eric.chung@riscstar.com>
Cc: u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org,
Tim Ouyang <tim609@andestech.com>,
Leo Liang <leo.liang@sifive.com>, Yao Zi <me@ziyao.cc>,
Huan Zhou <pericycle.cc@gmail.com>, Tom Rini <trini@konsulko.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Yixun Lan <dlan@kenrel.org>
Subject: Re: [PATCH 0/2] pinctrl: fix on Spacemit K1 SoC
Date: Sat, 5 Sep 2026 11:36:17 +0000 [thread overview]
Message-ID: <20260905113617-GKC84986@kernel.org> (raw)
In-Reply-To: <20260824-pinctrl-v1-0-e02ed7e9309f@riscstar.com>
Hi Eric,
On 16:13 Mon 24 Aug , Eric Chung wrote:
> - Add IO power domain control register programming via APBC block with
> ASAR unlocking for dual-voltage GPIO banks (3.3V/1.8V switching)
> - Fix drive strength configuration: use FIELD_PREP(), preserve io_type,
> return correct pin number, and remove redundant initialization
>
You should mention this is split from previous mmc series
I previous have some comments for patch 1 which you missed?
also you lost my review tags, or should explain if not applying the tags
https://lore.kernel.org/all/20260817021216-GKB566872@kernel.org/
https://lore.kernel.org/all/20260817024807-GKC566872@kernel.org/
> Signed-off-by: Eric Chung <eric.chung@riscstar.com>
>
> ---
> Eric Chung (2):
> pinctrl: k1: fix drive strength configuration
> pinctrl: k1: add IO power domain configuration support
>
> drivers/pinctrl/spacemit/pinctrl-k1.c | 107 +++++++++++++++++++++++++++++++---
> 1 file changed, 100 insertions(+), 7 deletions(-)
> ---
> base-commit: 6073c36b2c8d39afe3ecc789b281667a3ddebc70
> change-id: 20260824-pinctrl-718fe50eb9f8
>
> Best regards,
> --
> Eric Chung <eric.chung@riscstar.com>
>
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-09-05 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 8:13 [PATCH 0/2] pinctrl: fix on Spacemit K1 SoC Eric Chung
2026-08-24 8:13 ` [PATCH 1/2] pinctrl: k1: fix drive strength configuration Eric Chung
2026-08-24 8:14 ` [PATCH 2/2] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-09-02 1:52 ` [PATCH 0/2] pinctrl: fix on Spacemit K1 SoC Eric Chung
2026-09-05 11:36 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905113617-GKC84986@kernel.org \
--to=dlan@kernel.org \
--cc=dlan@kenrel.org \
--cc=eric.chung@riscstar.com \
--cc=leo.liang@sifive.com \
--cc=me@ziyao.cc \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.