From: Igor Paunovic <royalnet026@gmail.com>
To: sashiko-bot@kernel.org
Cc: Igor Paunovic <royalnet026@gmail.com>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>,
Sidong Yang <sidong.yang@furiosa.ai>,
Heiko Stuebner <heiko@sntech.de>,
Jiaxing Hu <gahing@gahingwoo.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accel/rocket: search every core slot when looking up a scheduler
Date: Sat, 5 Sep 2026 17:27:59 +0200 [thread overview]
Message-ID: <20260905152804.9822-1-royalnet026@gmail.com> (raw)
In-Reply-To: <20260905151815.3BE7F1F00A3A@smtp.kernel.org>
> - [Critical] The patch introduces a compilation failure by referencing an
> undefined struct member `max_cores` in `struct rocket_device`.
Correct on its own, and my fault for leaving it to a trailer.
max_cores is added by "accel/rocket: search every core slot when a core is
removed", still on the list:
https://lore.kernel.org/dri-devel/20260904125936.26234-1-royalnet026@gmail.com/
This patch declares that dependency as prerequisite-patch-id, and the id in
it matches git patch-id of that patch exactly. On top of it the build is
clean with W=1. On its own it does not build, as you say - it should have
said so in plain text below the --- as well, not only in the trailer. I
will do that on any patch of mine that depends on a pending one.
The pre-existing issues are useful, and two of them are already in hand: the
global rdev left holding an ERR_PTR, and the devm allocations on drm_dev->dev
that are never freed. The reset work cancelled after drm_sched_fini, and the
iommu_group reference taken in the IRQ handler, I had not seen. I will not
send patches for them until I have reproduced them on hardware - the two bugs
I did send this week both looked different once a KASAN kernel had printed
the trace.
Igor
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Igor Paunovic <royalnet026@gmail.com>
To: sashiko-bot@kernel.org
Cc: Igor Paunovic <royalnet026@gmail.com>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>,
Sidong Yang <sidong.yang@furiosa.ai>,
Heiko Stuebner <heiko@sntech.de>,
Jiaxing Hu <gahing@gahingwoo.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accel/rocket: search every core slot when looking up a scheduler
Date: Sat, 5 Sep 2026 17:27:59 +0200 [thread overview]
Message-ID: <20260905152804.9822-1-royalnet026@gmail.com> (raw)
In-Reply-To: <20260905151815.3BE7F1F00A3A@smtp.kernel.org>
> - [Critical] The patch introduces a compilation failure by referencing an
> undefined struct member `max_cores` in `struct rocket_device`.
Correct on its own, and my fault for leaving it to a trailer.
max_cores is added by "accel/rocket: search every core slot when a core is
removed", still on the list:
https://lore.kernel.org/dri-devel/20260904125936.26234-1-royalnet026@gmail.com/
This patch declares that dependency as prerequisite-patch-id, and the id in
it matches git patch-id of that patch exactly. On top of it the build is
clean with W=1. On its own it does not build, as you say - it should have
said so in plain text below the --- as well, not only in the trailer. I
will do that on any patch of mine that depends on a pending one.
The pre-existing issues are useful, and two of them are already in hand: the
global rdev left holding an ERR_PTR, and the devm allocations on drm_dev->dev
that are never freed. The reset work cancelled after drm_sched_fini, and the
iommu_group reference taken in the IRQ handler, I had not seen. I will not
send patches for them until I have reproduced them on hardware - the two bugs
I did send this week both looked different once a KASAN kernel had printed
the trace.
Igor
next prev parent reply other threads:[~2026-09-05 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 15:04 [PATCH] accel/rocket: search every core slot when looking up a scheduler Igor Paunovic
2026-09-05 15:04 ` Igor Paunovic
2026-09-05 15:18 ` sashiko-bot
2026-09-05 15:27 ` Igor Paunovic [this message]
2026-09-05 15:27 ` Igor Paunovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905152804.9822-1-royalnet026@gmail.com \
--to=royalnet026@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gahing@gahingwoo.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ogabbay@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sidong.yang@furiosa.ai \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.