* [paulmckrcu:dev 27/42] kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting
@ 2026-09-05 12:25 kernel test robot
2026-09-08 19:11 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-09-05 12:25 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: oe-kbuild-all, David Woodhouse
tree: https://github.com/paulmckrcu/linux dev
head: 3fe004c1cd8588480a29f9577427cf8a9daa32d1
commit: a6b38e2d5585400c21ee2429683f2ab7ec0e1cf8 [27/42] srcutree: Add an atomic Tree SRCU
config: x86_64-randconfig-161-20260904 (https://download.01.org/0day-ci/archive/20260905/202609052019.8XxNMFvN-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609052019.8XxNMFvN-lkp@intel.com/
smatch warnings:
kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting
kernel/rcu/srcutree.c:2148 synchronize_srcu_atomic() warn: inconsistent indenting
vim +913 kernel/rcu/srcutree.c
905
906 /*
907 * Start an SRCU grace period.
908 */
909 static void srcu_gp_start(struct srcu_struct *ssp)
910 {
911 int state;
912
> 913 /*&&&&*/pr_alert("%s() start: ->srcu_gp_seq: %lx ->srcu_gp_seq_needed: %lx\n", __func__, ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed);
914 lockdep_assert_held(&ACCESS_PRIVATE(ssp->srcu_sup, lock));
915 WARN_ON_ONCE(ULONG_CMP_GE(ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed));
916 WRITE_ONCE(ssp->srcu_sup->srcu_gp_start, jiffies);
917 WRITE_ONCE(ssp->srcu_sup->srcu_n_exp_nodelay, 0);
918 smp_mb(); /* Order prior store to ->srcu_gp_seq_needed vs. GP start. */
919 rcu_seq_start(&ssp->srcu_sup->srcu_gp_seq);
920 state = rcu_seq_state(ssp->srcu_sup->srcu_gp_seq);
921 WARN_ON_ONCE(state != SRCU_STATE_SCAN1);
922 }
923
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [paulmckrcu:dev 27/42] kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting
2026-09-05 12:25 [paulmckrcu:dev 27/42] kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting kernel test robot
@ 2026-09-08 19:11 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2026-09-08 19:11 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, David Woodhouse
On Sat, Sep 05, 2026 at 08:25:52PM +0800, kernel test robot wrote:
> tree: https://github.com/paulmckrcu/linux dev
> head: 3fe004c1cd8588480a29f9577427cf8a9daa32d1
> commit: a6b38e2d5585400c21ee2429683f2ab7ec0e1cf8 [27/42] srcutree: Add an atomic Tree SRCU
> config: x86_64-randconfig-161-20260904 (https://download.01.org/0day-ci/archive/20260905/202609052019.8XxNMFvN-lkp@intel.com/config)
> compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
> smatch: v0.5.0-9187-g5189e3fb
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202609052019.8XxNMFvN-lkp@intel.com/
>
> smatch warnings:
> kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting
> kernel/rcu/srcutree.c:2148 synchronize_srcu_atomic() warn: inconsistent indenting
This is debug code and will be removed, but thank you for the reminder.
Thanx, Paul
> vim +913 kernel/rcu/srcutree.c
>
> 905
> 906 /*
> 907 * Start an SRCU grace period.
> 908 */
> 909 static void srcu_gp_start(struct srcu_struct *ssp)
> 910 {
> 911 int state;
> 912
> > 913 /*&&&&*/pr_alert("%s() start: ->srcu_gp_seq: %lx ->srcu_gp_seq_needed: %lx\n", __func__, ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed);
> 914 lockdep_assert_held(&ACCESS_PRIVATE(ssp->srcu_sup, lock));
> 915 WARN_ON_ONCE(ULONG_CMP_GE(ssp->srcu_sup->srcu_gp_seq, ssp->srcu_sup->srcu_gp_seq_needed));
> 916 WRITE_ONCE(ssp->srcu_sup->srcu_gp_start, jiffies);
> 917 WRITE_ONCE(ssp->srcu_sup->srcu_n_exp_nodelay, 0);
> 918 smp_mb(); /* Order prior store to ->srcu_gp_seq_needed vs. GP start. */
> 919 rcu_seq_start(&ssp->srcu_sup->srcu_gp_seq);
> 920 state = rcu_seq_state(ssp->srcu_sup->srcu_gp_seq);
> 921 WARN_ON_ONCE(state != SRCU_STATE_SCAN1);
> 922 }
> 923
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-08 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 12:25 [paulmckrcu:dev 27/42] kernel/rcu/srcutree.c:913 srcu_gp_start() warn: inconsistent indenting kernel test robot
2026-09-08 19:11 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.