From: Rupesh Majhi <zoone.rupert@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Bill Wendling" <morbo@google.com>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
"Justin Stitt" <justinstitt@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v6 4/6] iio: pressure: dps310: add triggered buffer support
Date: Sun, 6 Sep 2026 13:06:53 +0300 [thread overview]
Message-ID: <20260906100707.435298-1-zoone.rupert@gmail.com> (raw)
In-Reply-To: <ao1bBFkLXIIgNl49@ashevche-desk.local>
On Tue, 25 Aug 2026 12:06:12 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> Hmm... Is scoped_guard() too bad here?
Jonathan asked for the plain form on this handler in the v5 review:
It isn't necessary to use guard/scoped_guard() for all locks in a
driver if they actually hurt readability. I think that is the case
here.
So it stays as mutex_lock/unlock with the goto. guard() is kept where the
lock runs to the end of the function.
> Side note, at some point makes sense to move from 1000 to KILO.
The site above it is pre-existing, so both should move together in the
cleanup series rather than leaving one spelled each way here.
Rupesh
next prev parent reply other threads:[~2026-09-06 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 20:11 [PATCH v6 0/6] iio: pressure: dps310: FIFO and triggered buffer support Rupesh Majhi
2026-08-24 20:11 ` [PATCH v6 1/6] iio: pressure: dps310: fix CFG_REG bit definitions Rupesh Majhi
2026-08-24 20:11 ` [PATCH v6 2/6] iio: pressure: dps310: use a local device pointer in probe Rupesh Majhi
2026-08-24 20:12 ` [PATCH v6 3/6] iio: pressure: dps310: rework the raw read paths Rupesh Majhi
2026-08-25 8:59 ` Andy Shevchenko
2026-08-24 20:12 ` [PATCH v6 4/6] iio: pressure: dps310: add triggered buffer support Rupesh Majhi
2026-08-25 9:06 ` Andy Shevchenko
2026-08-31 0:41 ` Jonathan Cameron
2026-08-31 7:03 ` Andy Shevchenko
2026-09-06 10:06 ` Rupesh Majhi [this message]
2026-08-31 1:14 ` Jonathan Cameron
2026-08-24 20:12 ` [PATCH v6 5/6] iio: pressure: dps310: add hardware FIFO support Rupesh Majhi
2026-08-25 9:39 ` Andy Shevchenko
2026-09-06 10:07 ` Rupesh Majhi
2026-08-31 1:14 ` Jonathan Cameron
2026-09-06 9:45 ` Rupesh Majhi
2026-09-10 2:36 ` Jonathan Cameron
2026-08-24 20:12 ` [PATCH v6 6/6] iio: pressure: dps310: check the lock markings with context analysis Rupesh Majhi
2026-08-31 1:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906100707.435298-1-zoone.rupert@gmail.com \
--to=zoone.rupert@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=justinstitt@google.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.