From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Rupesh Majhi" <zoone.rupert@gmail.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Bill Wendling" <morbo@google.com>,
"David Lechner" <dlechner@baylibre.com>,
"Eddie James" <eajames@linux.ibm.com>,
"Joel Stanley" <joel@jms.id.au>,
"Justin Stitt" <justinstitt@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v6 4/6] iio: pressure: dps310: add triggered buffer support
Date: Mon, 31 Aug 2026 10:03:01 +0300 [thread overview]
Message-ID: <apUnJb6jODnbSw42@ashevche-desk.local> (raw)
In-Reply-To: <178813690647.2788519.5367342639957476343.b4-reply@b4>
On Mon, Aug 31, 2026 at 01:41:46AM +0100, Jonathan Cameron wrote:
> On 2026-08-25 12:06:12+03:00, Andy Shevchenko wrote:
> > On Mon, Aug 24, 2026 at 11:12:01PM +0300, Rupesh Majhi wrote:
...
> > > +struct dps310_scan {
> > > + s32 channels[2];
> > > + aligned_s64 ts;
> > > +};
> >
> > Wondering if using macro here would make sense...
>
> Do you mean introducing a new one or using the buffer ones? I'd
> rather keep explicit structures where possible. They are much easier
> to reead as they make the data layout explicit, including the holes
> (as long as folk remember their c structure alignments!)
> - no holes here obviously!
>
> We only introduced the IIO_BUFFER macros to cover the cases we
> can't represent as a structure because the timestamp moves
> around as the number of channels enabled changes. Necessary
> trick to reduce the size of the kfifos.
Yeah, I got it. I need to remember your preference for the future.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-31 7:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 20:11 [PATCH v6 0/6] iio: pressure: dps310: FIFO and triggered buffer support Rupesh Majhi
2026-08-24 20:11 ` [PATCH v6 1/6] iio: pressure: dps310: fix CFG_REG bit definitions Rupesh Majhi
2026-08-24 20:11 ` [PATCH v6 2/6] iio: pressure: dps310: use a local device pointer in probe Rupesh Majhi
2026-08-24 20:12 ` [PATCH v6 3/6] iio: pressure: dps310: rework the raw read paths Rupesh Majhi
2026-08-25 8:59 ` Andy Shevchenko
2026-08-24 20:12 ` [PATCH v6 4/6] iio: pressure: dps310: add triggered buffer support Rupesh Majhi
2026-08-25 9:06 ` Andy Shevchenko
2026-08-31 0:41 ` Jonathan Cameron
2026-08-31 7:03 ` Andy Shevchenko [this message]
2026-09-06 10:06 ` Rupesh Majhi
2026-08-31 1:14 ` Jonathan Cameron
2026-08-24 20:12 ` [PATCH v6 5/6] iio: pressure: dps310: add hardware FIFO support Rupesh Majhi
2026-08-25 9:39 ` Andy Shevchenko
2026-09-06 10:07 ` Rupesh Majhi
2026-08-31 1:14 ` Jonathan Cameron
2026-09-06 9:45 ` Rupesh Majhi
2026-09-10 2:36 ` Jonathan Cameron
2026-08-24 20:12 ` [PATCH v6 6/6] iio: pressure: dps310: check the lock markings with context analysis Rupesh Majhi
2026-08-31 1:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apUnJb6jODnbSw42@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=justinstitt@google.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nuno.sa@analog.com \
--cc=zoone.rupert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.