From: Simon Horman <horms@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>
Subject: Re: [PATCH] zorro: use module_driver() to avoid repeated boilerplate code
Date: Sun, 6 Sep 2026 11:17:47 +0100 [thread overview]
Message-ID: <20260906101747.GH40544@horms.kernel.org> (raw)
In-Reply-To: <20260906034037.81379-1-enelsonmoore@gmail.com>
On Sat, Sep 05, 2026 at 08:40:19PM -0700, Ethan Nelson-Moore wrote:
> Many Zorro drivers have module_init and module_exit functions that only
> call zorro_register_driver() and zorro_unregister_driver(). The
> module_driver() macro automatically generates these functions given the
> register and unregister functions. Switch to it to simplify the code.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/net/ethernet/8390/hydra.c | 13 +------------
> drivers/net/ethernet/8390/zorro8390.c | 13 +------------
> drivers/net/ethernet/amd/a2065.c | 13 +------------
> drivers/net/ethernet/amd/ariadne.c | 13 +------------
> drivers/scsi/a2091.c | 12 +-----------
> drivers/scsi/gvp11.c | 12 +-----------
> drivers/scsi/zorro7xx.c | 13 +------------
> drivers/scsi/zorro_esp.c | 13 +------------
> 8 files changed, 8 insertions(+), 94 deletions(-)
I think it would be best to split this patch up on a per-subsystem
of per driver basis. And send patches to appropriate subsystems.
In particular, please break out the net/ changes into a patchset
for net-next.
--
pw-bot: changes-requested
prev parent reply other threads:[~2026-09-06 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 3:40 [PATCH] zorro: use module_driver() to avoid repeated boilerplate code Ethan Nelson-Moore
2026-09-06 6:29 ` Uwe Kleine-König (The Capable Hub)
2026-09-06 10:17 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906101747.GH40544@horms.kernel.org \
--to=horms@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.