Re: [PATCH] zorro: use module_driver() to avoid repeated boilerplate code

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2061 bytes --]

On Sat, Sep 05, 2026 at 08:40:19PM -0700, Ethan Nelson-Moore wrote:
> Many Zorro drivers have module_init and module_exit functions that only
> call zorro_register_driver() and zorro_unregister_driver(). The
> module_driver() macro automatically generates these functions given the
> register and unregister functions. Switch to it to simplify the code.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
>  drivers/net/ethernet/8390/hydra.c     | 13 +------------
>  drivers/net/ethernet/8390/zorro8390.c | 13 +------------
>  drivers/net/ethernet/amd/a2065.c      | 13 +------------
>  drivers/net/ethernet/amd/ariadne.c    | 13 +------------
>  drivers/scsi/a2091.c                  | 12 +-----------
>  drivers/scsi/gvp11.c                  | 12 +-----------
>  drivers/scsi/zorro7xx.c               | 13 +------------
>  drivers/scsi/zorro_esp.c              | 13 +------------
>  8 files changed, 8 insertions(+), 94 deletions(-)


> 
> diff --git a/drivers/net/ethernet/8390/hydra.c b/drivers/net/ethernet/8390/hydra.c
> index 9a59915436d2..2edf97e500df 100644
> --- a/drivers/net/ethernet/8390/hydra.c
> +++ b/drivers/net/ethernet/8390/hydra.c
> @@ -257,18 +257,7 @@ static void hydra_remove_one(struct zorro_dev *z)
>      free_netdev(dev);
>  }
>  
> -static int __init hydra_init_module(void)
> -{
> -    return zorro_register_driver(&hydra_driver);
> -}
> -
> -static void __exit hydra_cleanup_module(void)
> -{
> -    zorro_unregister_driver(&hydra_driver);
> -}
> -
> -module_init(hydra_init_module);
> -module_exit(hydra_cleanup_module);
> +module_driver(hydra_driver, zorro_register_driver, zorro_unregister_driver);

If there was

#define module_zorro_driver(__platform_driver) \
        module_driver(__platform_driver, zorro_register_driver, zorro_unregister_driver)

this could be reduced to just

+module_zorro_driver(hydra_driver);

.

With or without that addition I like the patch.

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]