Re: [PATCH 3/3] drm/panel: ebbg-ft8719: Split initialization into enable/disable fn

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving DCS initialization commands from `.prepare()` to `.enable()` causes them to be sent after the DSI video stream has started, breaking panel initialization on many hosts.
--

commit 894224e238d4b672a8a8f36dbdfc03846d1bec2e
Author: David Heidelberg <david@ixit.cz>

drm/panel: ebbg-ft8719: Split initialization into enable/disable fn

This commit splits the panel initialization by removing the ebbg_ft8719_on()
and ebbg_ft8719_off() calls from the prepare and unprepare callbacks, and
mapping them directly to the enable and disable callbacks.

> diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c
> index 14982263a94f1..9965f46f1a316 100644
> --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c
> +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c
> @@ -54,8 +54,9 @@ static void ebbg_ft8719_reset(struct ebbg_ft8719 *ctx)
>  	usleep_range(15000, 16000);
>  }
>  
> -static int ebbg_ft8719_on(struct ebbg_ft8719 *ctx)
> +static int ebbg_ft8719_enable(struct drm_panel *panel)
>  {
> +	struct ebbg_ft8719 *ctx = to_ebbg_ft8719(panel);
>  	struct mipi_dsi_device *dsi = ctx->dsi;
>  	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };

[Severity: High]
Does moving the DCS initialization commands into the panel's enable callback
cause them to be sent too late?

The DRM bridge framework calls the panel's enable callback only after calling
enable on the host controller, which typically starts the video stream.

If ebbg_ft8719_enable() now sends DCS commands like MIPI_DCS_EXIT_SLEEP_MODE
after the high-speed video stream has started, will they fail or be ignored by
the panel, breaking the display initialization?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-ebbg-ft8719-fixups-v1-0-4e846510cad1@ixit.cz?part=3