Re: [PATCH 4/6] arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The device tree node uses an undocumented and unsupported compatible string 'qcom,pm8010-i2c' with no corresponding dt-bindings or driver implementations in the kernel tree.
- [Medium] The PM8010 PMIC node is missing an `interrupts` property, which is architecturally necessary for I2C PMICs to signal thermal alarms and faults.
--

commit c57ad5fec12bca214fc8171c9ab4ce19cbc0631e
Author: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC

This commit adds a new device tree node for the PM8010 PMIC over I2C to the 
Glymur CRD. It configures the PMIC's seven LDO regulators, reset GPIO, and 
associated pinctrl states.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index 4df3ccfee106a..68a191890b7d8 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -671,6 +671,66 @@ ptn3222_1: redriver@47 {
>  
>  		#phy-cells = <0>;
>  	};
> +
> +	pm8010: pmic@8 {
> +		compatible = "qcom,pm8010-i2c";

[Severity: Medium]
Will this compatible string match an existing driver? The "qcom,pm8010-i2c" 
compatible string appears to be undocumented and unsupported in the kernel
tree.

When building device trees with make dtbs_check, this will result in 
validation failures since there are no corresponding dt-bindings. The pm8010
device node will also remain inactive because no driver core can match it, 
leaving the PMIC and its regulators uninitialized.

> +		reg = <0x8>;
> +
> +		reset-gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
> +
> +		vdd-l1-l2-supply = <&vreg_l6p>;

[Severity: Medium]
Should this PM8010 PMIC node include an interrupts property?

The pm8010 node in arch/arm64/boot/dts/qcom/glymur-crd.dtsi defines a reset
line but is missing an interrupt line, which is architecturally necessary
for I2C PMICs to signal thermal alarms and faults.

Without an interrupt line, the SoC cannot respond to critical PMIC hardware
events like over-temperature or over-current faults. Additionally, if a 
future driver follows standard Qualcomm I2C PMIC patterns, passing a missing
IRQ to devm_regmap_add_irq_chip_fwnode() will cause the driver probe to fail
entirely with -EINVAL.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-glymur_camss_dts-v1-0-6c2ced5ea5f9@oss.qualcomm.com?part=4