[auh][PATCH] steps: ignore source in commit msg

[auh][PATCH] steps: ignore source in commit msg

[daniel.turull]

From: Daniel Turull <daniel.turull@ericsson.com>

The source is useful for identifying where the changelog comes from,
but it does not need to be included in the commit message.

Keep it only if it is a URL.

Signed-off-by: Daniel Turull <daniel.turull@ericsson.com>
---
 modules/steps.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/steps.py b/modules/steps.py
index a88e666..4adb23f 100644
--- a/modules/steps.py
+++ b/modules/steps.py
@@ -103,6 +103,8 @@ def _append_changelog_to_commit_msg(group, opts):
         text = p['changelog_text'].strip()
         if text.startswith('Changelog for '):
             text = text[text.index('\n') + 1:].strip()
+        if text.startswith('Source: ') and not text.startswith('Source: http'):
+            text = text[text.index('\n') + 1:].strip()
         if len(text) > max_len:
             text = (text[:max_len] + "\n\n[Changelog truncated as it exceeds {} characters; \n"
                     "the full changelog can be found in an attachment to the AUH email]".format(max_len))

Re: [auh][PATCH] steps: ignore source in commit msg

[Alexander Kanavin]

On Mon, 7 Sept 2026 at 15:14, <daniel.turull@ericsson.com> wrote:
> @@ -103,6 +103,8 @@ def _append_changelog_to_commit_msg(group, opts):
>          text = p['changelog_text'].strip()
>          if text.startswith('Changelog for '):
>              text = text[text.index('\n') + 1:].strip()
> +        if text.startswith('Source: ') and not text.startswith('Source: http'):
> +            text = text[text.index('\n') + 1:].strip()
>          if len(text) > max_len:
>              text = (text[:max_len] + "\n\n[Changelog truncated as it exceeds {} characters; \n"
>                      "the full changelog can be found in an attachment to the AUH email]".format(max_len))

This code block relies on brittle particularities of how devtool
writes out the changelog file. I wonder if we can rather make it more
structured, e.g. devtool writes out a json with all the metadata
including the pointer (filename) where the actual changelog text is,
and then auh can pick and format pieces the way it wants?

Alex

Re: [auh][PATCH] steps: ignore source in commit msg

[Daniel Turull]

On Wed, 2026-09-09 at 10:41 +0200, Alexander Kanavin wrote:
> On Mon, 7 Sept 2026 at 15:14, <daniel.turull@ericsson.com> wrote:
> > @@ -103,6 +103,8 @@ def _append_changelog_to_commit_msg(group, opts):
> >          text = p['changelog_text'].strip()
> >          if text.startswith('Changelog for '):
> >              text = text[text.index('\n') + 1:].strip()
> > +        if text.startswith('Source: ') and not text.startswith('Source:
> > http'):
> > +            text = text[text.index('\n') + 1:].strip()
> >          if len(text) > max_len:
> >              text = (text[:max_len] + "\n\n[Changelog truncated as it
> > exceeds {} characters; \n"
> >                      "the full changelog can be found in an attachment to
> > the AUH email]".format(max_len))
> 
> This code block relies on brittle particularities of how devtool
> writes out the changelog file. I wonder if we can rather make it more
> structured, e.g. devtool writes out a json with all the metadata
> including the pointer (filename) where the actual changelog text is,
> and then auh can pick and format pieces the way it wants?
> 
> Alex

Hi,

Should we have the metadata in a separate file and keep a pure text with only
the changelog? otherwise it may be less human friendly for people using the
changelog text without the AUH.

metadata:
 - packgage
 - old version
 - new version
 - filename of the changelog
 - changelog text or filename with the changelog text

Cheers
Daniel