Re: [PATCH v3] arm64: dts: nuvoton: ma35d1: add CAN nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The CAN controller nodes omit the hardware `resets` property, despite the SoC providing dedicated CAN reset lines.
--

commit bc194563299d88a0e0b218c2bff6562e1d264119
Author: Zi-Yu Chen <zychennvt@gmail.com>

arm64: dts: nuvoton: ma35d1: add CAN nodes

This commit adds controller nodes for the four Bosch M_CAN blocks found
on the Nuvoton MA35D1 SoC. It also configures pinctrl, enables CAN1 and
CAN3 on the SOM board, and updates the APLL frequency.

> diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
> index 7228ad4735b5c..91c0abc1678f2 100644
> --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
[ ... ]
> @@ -244,6 +244,58 @@ gpion: gpio@340 {
>  			};
>  		};
>  
> +		can0: can@403c0000 {
> +			compatible = "bosch,m_can";
> +			reg = <0x0 0x403c0000 0x0 0x200>, <0x0 0x403c0200 0x0 0x2000>;
> +			reg-names = "m_can", "message_ram";
> +			interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "int0", "int1";
> +			clocks = <&clk HCLK3>, <&clk CAN0_GATE>;
> +			clock-names = "hclk", "cclk";
> +			bosch,mram-cfg = <0x0 4 4 32 32 32 8 8>;
> +			status = "disabled";
> +		};

[Severity: Medium]
Should this node include the hardware resets property (e.g.,
resets = <&sys MA35D1_RESET_CANFD0>;)?

Without the hardware reset line, the bosch,m_can driver cannot perform a
hardware reset of the CAN controllers during probe or interface toggles.
It must rely solely on software initialization, which can fail to fully
recover the controller if the bootloader or a prior crashed state left
the hardware in an unpredictable state.

This omission pattern is identically repeated across the newly added can1,
can2, and can3 nodes below.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908014526.413399-1-zychennvt@gmail.com?part=1