Re: [PATCH v3] arm64: dts: nuvoton: ma35d1: add CAN nodes

[Jacky Huang <ychuang570808@gmail.com>]

> [ ... ]
>> @@ -244,6 +244,58 @@ gpion: gpio@340 {
>>                        };
>>                };
>>
>> +             can0: can@403c0000 {
>> +                     compatible = "bosch,m_can";
>> +                     reg = <0x0 0x403c0000 0x0 0x200>, <0x0 0x403c0200 0x0 0x2000>;
>> +                     reg-names = "m_can", "message_ram";
>> +                     interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
>> +                                  <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
>> +                     interrupt-names = "int0", "int1";
>> +                     clocks = <&clk HCLK3>, <&clk CAN0_GATE>;
>> +                     clock-names = "hclk", "cclk";
>> +                     bosch,mram-cfg = <0x0 4 4 32 32 32 8 8>;
>> +                     status = "disabled";
>> +             };
> [Severity: Medium]
> Should this node include the hardware resets property (e.g.,
> resets = <&sys MA35D1_RESET_CANFD0>;)?
>
> Without the hardware reset line, the bosch,m_can driver cannot perform a
> hardware reset of the CAN controllers during probe or interface toggles.
> It must rely solely on software initialization, which can fail to fully
> recover the controller if the bootloader or a prior crashed state left
> the hardware in an unpredictable state.
>
> This omission pattern is identically repeated across the newly added can1,
> can2, and can3 nodes below.

The reset property is optional for the MA35D1 CAN nodes.

The bosch,m_can binding does not require a reset property, and the
m_can driver obtains the reset control through
devm_reset_control_get_optional_shared().

The MA35D1 CAN controllers also operate correctly without explicit
CAN reset properties in the existing platform DTS. Therefore, no
change is required for this patch.


> [ ... ]
>
> --
> Sashiko AI review · https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsashiko.dev%2F%23%2Fpatchset%2F20260908014526.413399-1-zychennvt%40gmail.com%3Fpart%3D1&data=05%7C02%7Cychuang3%40nuvoton.com%7C0f6b077d07ea424b0be208df0d4c30cd%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C639244293026922482%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=mOpnaGY2o1KYf6Z5OXNovFUJbA6M5WauNCVif8Ihfn4%3D&reserved=0
>